add method run_middlewares (#199)

* fix ci

* add method run_middlewares

Author: nggit

.github/workflows/tests_and_coverage.yml

@@ -30,17 +30,13 @@ jobs:
           fetch-depth: 2
 
       - name: List the modified files
-        run: echo "FILES_MODIFIED=$(git diff --name-only HEAD HEAD^)" >> $GITHUB_ENV
+        run: echo "FILES_MODIFIED=$(git diff --name-only HEAD HEAD^ | xargs)" >> $GITHUB_ENV
         if: ${{ !startsWith(matrix.os, 'windows-') }}
 
       - name: List the modified files (Windows)
-        shell: cmd
         run: |
-          set "FILES_MODIFIED="
-          for /f "delims=" %%f in ('git diff --name-only HEAD HEAD^') do (
-            set "FILES_MODIFIED=%FILES_MODIFIED%;%%f"
-          )
-          echo FILES_MODIFIED=%FILES_MODIFIED% >> %GITHUB_ENV% 
+          $FILES_MODIFIED = $(git diff --name-only HEAD HEAD^) -join ' '
+          echo "FILES_MODIFIED=$FILES_MODIFIED" | Out-File -FilePath $env:GITHUB_ENV
         if: ${{ startsWith(matrix.os, 'windows-') }}
 
       - name: Setup Python

tremolo/http_server.py

@@ -65,6 +65,19 @@ def connection_lost(self, exc):
 
         self._server['response'] = None
 
+    async def run_middlewares(self, name, reverse=False, start=0, step=1):
+        if reverse:
+            start = len(self._middlewares[name]) - 1
+            step = -1
+
+        while 0 <= start < len(self._middlewares[name]):
+            if await self._handle_middleware(
+                    self._middlewares[name][start][1],
+                    self._middlewares[name][start][2]):
+                return True
+
+            start += step
+
     async def _handle_middleware(self, func, kwargs):
         options = self.request.context.options
         options.update(kwargs)
@@ -175,15 +188,8 @@ async def _handle_response(self, func, kwargs):
             else:
                 self.response.set_header(b'Connection', b'close')
 
-            i = len(self._middlewares['response'])
-
-            while i > 0:
-                i -= 1
-
-                if await self._handle_middleware(
-                        self._middlewares['response'][i][1],
-                        self._middlewares['response'][i][2]):
-                    return
+            if await self.run_middlewares('response', reverse=True):
+                return
 
             if self.request.method == b'HEAD' or no_content:
                 await self.response.write(None)
@@ -237,15 +243,8 @@ async def _handle_response(self, func, kwargs):
                 b'Connection', KEEPALIVE_OR_CLOSE[self.request.http_keepalive]
             )
 
-            i = len(self._middlewares['response'])
-
-            while i > 0:
-                i -= 1
-
-                if await self._handle_middleware(
-                        self._middlewares['response'][i][1],
-                        self._middlewares['response'][i][2]):
-                    return
+            if await self.run_middlewares('response', reverse=True):
+                return
 
             if self.request.method == b'HEAD' or no_content:
                 await self.response.write(None)
@@ -269,9 +268,8 @@ async def headers_received(self, response):
         if self._middlewares['connect']:
             await self.context.ON_CONNECT
 
-        for middleware in self._middlewares['request']:
-            if await self._handle_middleware(middleware[1], middleware[2]):
-                return
+        if await self.run_middlewares('request'):
+            return
 
         if not self.request.is_valid:
             # bad request