useEffectFn use with createEffectFn stop working after emitting error

[chris-fung]

Description
I found that any functions created from useEffectFn and createEffectFn won't work after emitting error.

Proposed solution
Any solution that let outer function continue working after error.

Alternatives considered
n/a

Do you want to create a pull request?
No

[NetanelBasal]

Can you share an example, please?

[chris-fung]

I mean, any code from pages like this:

import { useEffectFn } from '@ngneat/effects-hooks';

function SearchComponent() {
  const searchTodo = useEffectFn(searchTodoEffect);

  return <input onChange = {({ target: { value } }) => searchTodo(value) }/>
}

If the searchTodoEffect's logic goes to error or complete, we can't invoke page's searchTodo function anymore. I think the original problem is using rxjs Subject, if the stream complete or error, the Subject can't be used anymore. How can we fix this problem?

[netanel-utila]

You should handle it in searchTodoEffect stream.

[chris-fung]

I rewrited the createEffectFn and solved my problem. Of course, without using rxjs Subject.

My code:

export function createEffectFn<T>(factoryFn: (source: Observable<T>) => Observable<unknown>) {
  return function (destroyed$: Observable<boolean>) {
    return function (value: T) {
      factoryFn(of(value)).pipe(takeUntil(destroyed$)).subscribe();
    };
  };
}

The original createEffectFn code:

export function createEffectFn<T>(factoryFn: (source: Observable<T>) => Observable<unknown>) {
  return function (destroyed$: Observable<boolean>) {
    const subject = new Subject<T>();

    factoryFn(subject.asObservable()).pipe(takeUntil(destroyed$)).subscribe();

    return function (value: T) {
      subject.next(value);
    };
  };
}