Skip to content

Endpoints document is still using tunnels which is marked deprecated in Agent Config #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
southwolf opened this issue Nov 23, 2024 · 3 comments

Comments

@southwolf
Copy link

southwolf commented Nov 23, 2024

tunnels is marked as deprecated in Agent Config, but
Endpoints section is still using tunnels and has not migrated to endpoints yet. e.g.

tunnels:
  example:
    proto: http
    addr: 8080
    domain: example.ngrok.app

Should be updated / migrated to

endpoints:
  - name: example
    url: https://example.ngrok.app
    upstream:
      url: 8080

But I am not sure what is the best format to present. Should both endpoints & tunnels configurations be kept on the page but tunnels is marked deprecated? Or just remove tunnels and only leave endpoints?

@southwolf southwolf changed the title Agent Config in Endpoints document is still using tunnels which is marked deprecated Endpoints document is still using tunnels which is marked deprecated in Agent Config Nov 23, 2024
@southwolf
Copy link
Author

@russorat @joelhans Will this be included in #1050 or maybe next step after that? I saw you are also mentioning update documents about tunnels to endpoints

@chadwcarlson
Copy link

I believe this one could be closed and was addressed in #1105 and ad6ec94.

cc @nijikokun @S3Prototype

@RAFAEL849412
Copy link

Falhas então você tá falando usar URL se você quiser usar uma coisa do código corrigido então tente novamente atualizar o código eu entro em contato das pessoas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants