Skip to content

fix: Update manifest-bundle.yaml #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

jonstacks
Copy link
Collaborator

What

I noticed we aren't updating the manifest bundle and its fairly out of date. This adds a make command to easily keep this updated. We aren't doing any automation on this currently when we do a release and should think about doing that going forward. For now though, this updates it and gives us a consistent way to do that.

How

  • Add a make command for generating the manifest bundle
  • Update the GH workflow that referenced it

Breaking Changes

No

@jonstacks jonstacks added this to the controller-0.18.0 milestone Jun 24, 2025
@jonstacks jonstacks self-assigned this Jun 24, 2025
@jonstacks jonstacks requested a review from a team as a code owner June 24, 2025 16:09
@github-actions github-actions bot added the area/ci Issues/PRs relating to CI label Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.32%. Comparing base (9174677) to head (142a63b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #663   +/-   ##
=======================================
  Coverage   31.32%   31.32%           
=======================================
  Files         101      101           
  Lines       16165    16165           
=======================================
  Hits         5063     5063           
  Misses      10808    10808           
  Partials      294      294           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonstacks jonstacks added this pull request to the merge queue Jun 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2025
@jonstacks jonstacks added this pull request to the merge queue Jun 24, 2025
Merged via the queue into ngrok:main with commit a71456e Jun 24, 2025
10 checks passed
@jonstacks jonstacks deleted the manifest-bundle-generation branch June 24, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues/PRs relating to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants