Skip to content

[Breaking Change!] Remove Deprecated CRDs #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2025

Conversation

jonstacks
Copy link
Collaborator

More context can be found in #654

What

⚠️ Removing support for the following CRDs: ⚠️

  • HTTPSEdge
  • TLSEdge
  • TCPEdge
  • Tunnel
  • NgrokModuleSet

This PR removes all Edge related functionality from the operator. This will make it easier to maintain going forward.

How

Lots of deleting old code and updating tests for new behavior.

Breaking Changes

Yes, before upgrading to a version that includes this change, you should:

  1. Make sure you are not using the ngrok.k8s.com/mapping-strategy: edges annotation anywhere. If you are, you'll want to remove it or replace it with either endpoints or endpoints-verbose.
  2. Make sure you don't have any of the following resources:
kubectl get httpsedges.ingress.k8s.ngrok.com -A
kubectl get tlsedges.ingress.k8s.ngrok.com -A
kubectl get tcpedges.ingress.k8s.ngrok.com -A
kubectl get tunnels.ingress.k8s.ngrok.com -A
kubectl get ngrokmodulesets.ingress.k8s.ngrok.com -A

@jonstacks jonstacks added this to the controller-0.18.0 milestone Jun 26, 2025
@jonstacks jonstacks self-assigned this Jun 26, 2025
@jonstacks jonstacks requested a review from a team as a code owner June 26, 2025 19:55
@github-actions github-actions bot added documentation Improvements or additions to documentation testing area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart area/ci Issues/PRs relating to CI labels Jun 26, 2025
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 3.90625% with 123 lines in your changes missing coverage. Please review.

Project coverage is 37.54%. Comparing base (a71456e) to head (37f712a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/ingress/v1alpha1/zz_generated.deepcopy.go 0.00% 76 Missing ⚠️
internal/testutils/k8s-resources.go 0.00% 28 Missing ⚠️
internal/controller/ingress/service_controller.go 0.00% 8 Missing ⚠️
cmd/api-manager.go 0.00% 6 Missing ⚠️
pkg/managerdriver/domains.go 50.00% 4 Missing ⚠️
.../controller/ngrok/ngroktrafficpolicy_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   31.37%   37.54%   +6.17%     
==========================================
  Files         101       79      -22     
  Lines       16165    11564    -4601     
==========================================
- Hits         5071     4342     -729     
+ Misses      10802     6994    -3808     
+ Partials      292      228      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Alice-Lilith Alice-Lilith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry it took me a while to get to reviewing this. lgtm.
goodbye edges 🫡

@jonstacks jonstacks added this pull request to the merge queue Jul 8, 2025
Merged via the queue into ngrok:main with commit 981805a Jul 8, 2025
16 of 17 checks passed
@jonstacks jonstacks deleted the remove-deprecated-crds branch July 8, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues/PRs relating to CI area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart documentation Improvements or additions to documentation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants