Skip to content

feat: Migrate to ngrok-go v2 #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonstacks
Copy link
Collaborator

What

There is a new version of the ngrok-go SDK that will help us get rid of some of the code we were maintaining for forwarding connections.

How

  • Update to v2 of the ngrok-go SDK.
  • Removes our logic for forwarding in favor of the new forwarder in the SDK.
  • Refactors the tunnel driver into an agent driver

Breaking Changes

No.

@jonstacks jonstacks self-assigned this Jul 16, 2025
@jonstacks jonstacks requested a review from a team as a code owner July 16, 2025 20:05
@github-actions github-actions bot added the area/controller Issues dealing with the controller label Jul 16, 2025
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 16.31206% with 236 lines in your changes missing coverage. Please review.

Project coverage is 38.23%. Comparing base (981805a) to head (a6b95b0).

Files with missing lines Patch % Lines
pkg/agent/driver.go 0.00% 220 Missing ⚠️
cmd/agent-manager.go 0.00% 11 Missing ⚠️
...rnal/controller/agent/agent_endpoint_controller.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
+ Coverage   37.52%   38.23%   +0.71%     
==========================================
  Files          79       80       +1     
  Lines       11564    11390     -174     
==========================================
+ Hits         4339     4355      +16     
+ Misses       6996     6811     -185     
+ Partials      229      224       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant