Open
Description
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => https://github.com/ngxs/store/blob/master/CONTRIBUTING.md
[ ] Other... Please describe:
Current behavior
The emitter plugin TESTING is using a deprecated dependency with Angular 10.
Expected behavior
When I'm trying to use this plugin with Angular 10. I want to run tests without issues.
Minimal reproduction of the problem with instructions
When I'm using the out of the box solution for testing with the emitter. one of the dependencies. (ModuleWithProviders) now requires an argument. (The fix is quite small)...
In the file:
https://github.com/ngxs-labs/emitter/blob/master/emitter/testing/src/lib/store-test-bed.module.ts:10
should replace:
public static configureTestingModule(states: Type<any>[] = []): ModuleWithProviders[] {
with:
public static configureTestingModule(states: Type<any>[] = []): ModuleWithProviders<any>[] {
What is the motivation/use case for changing the behaviour?
Be able to run a test suit in Angular 10.
Environment
Libs:
- @angular/core version: 10.0.0
- @ngxs/store version: 3.6.2
- @ngxs-labs/emitter version: 2.0.0
For Tooling issues:
- Node version: v12.16.3
- Platform: Mac
Metadata
Metadata
Assignees
Labels
No labels