Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of 300 seconds JWT expiry time tests from the automated test suite #285

Open
AndrewGuiseley opened this issue Aug 13, 2019 · 4 comments
Assignees

Comments

@AndrewGuiseley
Copy link
Contributor

As agreed, please can the following 2 tests be removed from the automated test suite:

Expiry Time - greater than 300 seconds
Expiry Time - less than 300 seconds

Providers should only be validating that the exp claim value (i.e. that this time has not yet passed)

@AndrewGuiseley AndrewGuiseley changed the title Removal of 300 seconds expiry time tests from the automated test suite Removal of 300 seconds JWT expiry time tests from the automated test suite Aug 13, 2019
@jonnyry
Copy link
Member

jonnyry commented Aug 13, 2019

Just to mention the demonstrator intentionally continues to perform these checks (as additional consumer validations), whereas the provider systems are not expected to.

@Sado1234
Copy link
Contributor

Hi @jonnyry what are your thoughts, instead of deleting we place these type of tests in a 'DemonstratorFeature' file to continue checking the Demonstrator functionality?

@PeterGresty
Copy link
Collaborator

DemonstratorOnly.feature maybe - for even more clarity

@jonnyry
Copy link
Member

jonnyry commented Aug 16, 2019

Yes sounds like a reasonable idea. So long as the providers are clear they don't need to run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants