HIGH - PractionerSearch tests are rejecting valid identifiers

[KevinMayfield]

We are including GMC numbers in our Practitioner responses.

These are being rejected with the following:

Message:
Shouldly.ShouldAssertException : identifier.System
should be one of
["https://fhir.nhs.uk/Id/sds-user-id", "https://fhir.nhs.uk/Id/sds-role-profile-id"]
but was
"https://fhir.hl7.org.uk/Id/gmp-number"

gmp-number is valid according to the GP Connect specification.

https://nhsconnect.github.io/gpconnect/accessrecord_structured_development_resources_overview.html#common-identifier-systems

[KevinMayfield]

Can you pass this error onto the team behind swagger+reference implementation.

The example is mixing SDS ID and GMP numbers up https://orange.testlab.nhs.uk/swagger/v1/#/Foundations/get_Practitioner

Care Connect Reference Implementation also has the same problem (but I'm not working on that anymore :) )

[PeterGresty]

Hi, @KevinMayfield
We have discussed the issue you raised around gmp-number not being accepted and we agree that this should be an acceptable value. The fix for this will go into release 1.3.0 but to get you the fix now, I have created a new branch for you to use that is the release/1.2.3 branch plus the extra code to allow "https://fhir.hl7.org.uk/Id/gmp-number" to be an acceptable value for the Practitioner Search tests. The new branch is called : feature/1.2.3-GMP-identifier-fix. Please download and use for your testing. Any problems email me at: peter.gresty@nhs.net.

[Sado1234]

Past the details of the feature branch over to Microtest