Remove MMRV feature flag

This enables MMRV across the service and removes the ability to turn it
off.

Jira-Issue: MAV-3021

Author: thomasleese

app/lib/feature_flag_factory.rb

@@ -17,7 +17,6 @@ def self.call
   FEATURES_FOR_DEVELOPMENT = %i[
     dev_tools
     import_review_screen
-    mmrv
     reporting_api
     testing_api
   ].freeze

app/models/programme.rb

@@ -38,7 +38,7 @@ class InvalidType < StandardError
     "flu" => %w[Flu],
     "hpv" => %w[HPV],
     "menacwy" => %w[ACWYX4 MenACWY],
-    "mmr" => %w[MMR],
+    "mmr" => %w[MMR MMRV],
     "td_ipv" => %w[3-in-1 Td/IPV]
   }.freeze
 
@@ -124,17 +124,19 @@ def <=>(other) = type <=> other.type
 
   def variant_type = nil
 
-  def translation_key
-    mmr? && Flipper.enabled?(:mmrv) ? "mmr_and_mmrv" : type
-  end
+  def translation_key = mmr? ? "mmr_and_mmrv" : type
 
   TYPES.each do |programme_type|
     define_method("#{programme_type}?") { type == programme_type }
   end
 
-  def name = I18n.t(translation_key, scope: :programme_types)
+  def name
+    @name ||= I18n.t(translation_key, scope: :programme_types)
+  end
 
-  def name_in_sentence = flu? ? name.downcase : name
+  def name_in_sentence
+    @name_in_sentence = flu? ? name.downcase : name
+  end
 
   def variant_for(disease_types: nil, patient: nil)
     return self unless mmr?
@@ -152,12 +154,7 @@ def variant_for(disease_types: nil, patient: nil)
 
     return self if eligible_for_mmrv.nil?
 
-    variant_type =
-      if eligible_for_mmrv && Flipper.enabled?(:mmrv)
-        "mmrv"
-      else
-        "mmr"
-      end
+    variant_type = eligible_for_mmrv ? "mmrv" : "mmr"
 
     Programme::Variant.new(self, variant_type:)
   end
@@ -212,15 +209,7 @@ def default_dose_sequence = hpv? || flu? ? 1 : nil
 
   def maximum_dose_sequence = MAXIMUM_DOSE_SEQUENCES.fetch(type)
 
-  # TODO: add MMRV to IMPORT_NAMES once the MMRV flag is removed
-  def import_names
-    names = IMPORT_NAMES.fetch(type)
-    if Flipper.enabled?(:mmrv) && type == "mmr"
-      names + %w[MMRV]
-    else
-      names
-    end
-  end
+  def import_names = IMPORT_NAMES.fetch(type)
 
   def snomed_target_disease_codes = SNOMED_TARGET_DISEASE_CODES.fetch(type)
 

app/models/programme/variant.rb

@@ -33,7 +33,9 @@ def mmrv_variant? = variant_type == "mmrv"
 
   def translation_key = variant_type
 
-  def name = I18n.t(translation_key, scope: :programme_types)
+  def name
+    @name ||= I18n.t(translation_key, scope: :programme_types)
+  end
 
   def name_in_sentence = name
 

config/feature_flags.yml

@@ -44,5 +44,3 @@ reporting_api: Enables the Commissioner reporting component to authenticate to M
   statistics from /api/reporting/
 
 testing_api: Basic API useful for automated testing.
-
-mmrv: Adds support for MMRV vaccinations

spec/components/app_activity_log_component_spec.rb

@@ -535,7 +535,6 @@
   describe "vaccination records" do
     context "for the MMRV variant" do
       let(:programme) do
-        Flipper.enable(:mmrv)
         Programme.mmr.variant_for(
           disease_types: Programme::Variant::DISEASE_TYPES.fetch("mmrv")
         )

spec/components/app_patient_search_result_card_component_spec.rb

@@ -84,8 +84,6 @@
     let(:programme) { Programme.mmr }
     let(:programmes) { [programme] }
 
-    before { Flipper.enable(:mmrv) }
-
     context "with a patient not eligible for MMRV" do
       let(:patient) { create(:patient, date_of_birth: Date.new(2019, 1, 1)) }
 

spec/components/app_session_summary_component_spec.rb

@@ -39,8 +39,6 @@
     it { should have_link("Download the HPV consent form (PDF)") }
 
     context "for MMR(V) programme" do
-      before { Flipper.enable(:mmrv) }
-
       let(:programmes) { [Programme.mmr] }
 
       it { should have_link("Download the MMR consent form (PDF)") }
@@ -58,8 +56,6 @@
       end
 
       context "for MMR(V) programme" do
-        before { Flipper.enable(:mmrv) }
-
         let(:programmes) { [Programme.mmr] }
 
         it { should have_link("View the MMR online consent form") }

spec/components/app_vaccine_criteria_label_component_spec.rb

@@ -19,14 +19,14 @@
     let(:vaccine_methods) { %w[injection] }
     let(:without_gelatine) { false }
 
-    it { should have_content("Record MMR vaccination") }
+    it { should have_content("Record MMR(V) vaccination") }
 
     context "with gelatine-free injection" do
       let(:without_gelatine) { true }
 
       it do
         expect(rendered).to have_content(
-          "Record MMR vaccination with gelatine-free injection"
+          "Record MMR(V) vaccination with gelatine-free injection"
         )
       end
     end

spec/factories/patient_consent_statuses.rb

@@ -27,6 +27,7 @@
   factory :patient_consent_status, class: "Patient::ConsentStatus" do
     patient
     programme { Programme.sample }
+    disease_types { programme.disease_types }
     academic_year { AcademicYear.current }
 
     traits_for_enum :status

spec/factories/patient_programme_statuses.rb

@@ -29,8 +29,8 @@
 FactoryBot.define do
   factory :patient_programme_status, class: "Patient::ProgrammeStatus" do
     patient
-    academic_year { AcademicYear.current }
     programme { Programme.sample }
+    academic_year { AcademicYear.current }
 
     traits_for_enum :status