Remove MMRV feature flag

This enables MMRV across the service and removes the ability to turn it
off.

Author: thomasleese

app/lib/feature_flag_factory.rb

@@ -17,7 +17,6 @@ def self.call
   FEATURES_FOR_DEVELOPMENT = %i[
     dev_tools
     import_review_screen
-    mmrv
     reporting_api
     testing_api
   ].freeze

app/models/programme.rb

@@ -38,7 +38,7 @@ class InvalidType < StandardError
     "flu" => %w[Flu],
     "hpv" => %w[HPV],
     "menacwy" => %w[ACWYX4 MenACWY],
-    "mmr" => %w[MMR],
+    "mmr" => %w[MMR MMRV],
     "td_ipv" => %w[3-in-1 Td/IPV]
   }.freeze
 
@@ -124,17 +124,19 @@ def <=>(other) = type <=> other.type
 
   def variant_type = nil
 
-  def translation_key
-    mmr? && Flipper.enabled?(:mmrv) ? "mmr_and_mmrv" : type
-  end
+  def translation_key = mmr? ? "mmr_and_mmrv" : type
 
   TYPES.each do |programme_type|
     define_method("#{programme_type}?") { type == programme_type }
   end
 
-  def name = I18n.t(translation_key, scope: :programme_types)
+  def name
+    @name ||= I18n.t(translation_key, scope: :programme_types)
+  end
 
-  def name_in_sentence = flu? ? name.downcase : name
+  def name_in_sentence
+    @name_in_sentence = flu? ? name.downcase : name
+  end
 
   def variant_for(disease_types: nil, patient: nil)
     return self if (disease_types.blank? && patient.blank?) || !mmr?
@@ -152,12 +154,7 @@ def variant_for(disease_types: nil, patient: nil)
         false
       end
 
-    variant_type =
-      if eligible_for_mmrv && Flipper.enabled?(:mmrv)
-        "mmrv"
-      else
-        "mmr"
-      end
+    variant_type = eligible_for_mmrv ? "mmrv" : "mmr"
 
     Programme::Variant.new(self, variant_type:)
   end
@@ -212,15 +209,7 @@ def default_dose_sequence = hpv? || flu? ? 1 : nil
 
   def maximum_dose_sequence = MAXIMUM_DOSE_SEQUENCES.fetch(type)
 
-  # TODO: add MMRV to IMPORT_NAMES once the MMRV flag is removed
-  def import_names
-    names = IMPORT_NAMES.fetch(type)
-    if Flipper.enabled?(:mmrv) && type == "mmr"
-      names + %w[MMRV]
-    else
-      names
-    end
-  end
+  def import_names = IMPORT_NAMES.fetch(type)
 
   def snomed_target_disease_codes = SNOMED_TARGET_DISEASE_CODES.fetch(type)
 

app/models/programme/variant.rb

@@ -29,7 +29,9 @@ def initialize(programme, variant_type:)
 
   def translation_key = variant_type
 
-  def name = I18n.t(translation_key, scope: :programme_types)
+  def name
+    @name ||= I18n.t(translation_key, scope: :programme_types)
+  end
 
   def name_in_sentence = name
 

config/feature_flags.yml

@@ -42,5 +42,3 @@ reporting_api: Enables the Commissioner reporting component to authenticate to M
   statistics from /api/reporting/
 
 testing_api: Basic API useful for automated testing.
-
-mmrv: Adds support for MMRV vaccinations

spec/components/app_vaccine_criteria_label_component_spec.rb

@@ -19,14 +19,14 @@
     let(:vaccine_methods) { %w[injection] }
     let(:without_gelatine) { false }
 
-    it { should have_content("Record MMR vaccination") }
+    it { should have_content("Record MMR(V) vaccination") }
 
     context "with gelatine-free injection" do
       let(:without_gelatine) { true }
 
       it do
         expect(rendered).to have_content(
-          "Record MMR vaccination with gelatine-free injection"
+          "Record MMR(V) vaccination with gelatine-free injection"
         )
       end
     end

spec/features/edit_session_programmes_spec.rb

@@ -165,7 +165,7 @@ def then_i_see_the_warning_panel_about_unvaccinated_patients_for_hpv
 
   def then_i_see_the_warning_panel_about_unvaccinated_patients_for_mmr
     expect(page).to have_content(
-      "Have you imported historical vaccination records for MMR?"
+      "Have you imported historical vaccination records for MMR(V)?"
     )
     expect(page).to have_content(
       "0% of children in Years 8 to 11 in this session have vaccination " \
@@ -180,7 +180,7 @@ def then_i_see_the_warning_panel_about_unvaccinated_patients_for_mmr
 
   def then_i_see_the_warning_panel_about_unvaccinated_patients_for_hpv_and_mmr
     expect(page).to have_content(
-      "Have you imported historical vaccination records for HPV and MMR?"
+      "Have you imported historical vaccination records for HPV and MMR(V)?"
     )
     expect(page).to have_content(
       "0% of children in Years 8 to 11 in this session have vaccination " \

spec/features/mmr_vaccination_administered_spec.rb

@@ -107,26 +107,30 @@ def and_i_am_signed_in
   end
 
   def and_there_is_a_session_today_with_patients_safe_to_vaccinate
+    # These children need to be old enough so they're not eligible for MMRV.
     @without_gelatine_only_patient =
       create(
         :patient,
         :consent_given_without_gelatine_triage_not_needed,
         :in_attendance,
-        session: @session
+        session: @session,
+        year_group: 9
       )
     @without_gelatine_patient =
       create(
         :patient,
         :consent_given_triage_not_needed,
         :in_attendance,
-        session: @session
+        session: @session,
+        year_group: 9
       )
     @with_gelatine_patient =
       create(
         :patient,
         :consent_given_triage_not_needed,
         :in_attendance,
-        session: @session
+        session: @session,
+        year_group: 9
       )
   end
 

spec/features/mmrv_vaccination_administered_spec.rb

@@ -4,8 +4,7 @@
   around { |example| travel_to(Time.zone.local(2024, 10, 1)) { example.run } }
 
   scenario "administered at community clinic" do
-    given_mmrv_vaccinations_are_enabled
-    and_i_am_signed_in_as_a_nurse
+    given_i_am_signed_in_as_a_nurse
     and_a_patient_is_ready_for_mmrv_vaccination_in_a_community_clinic
 
     when_i_go_to_the_patients_tab
@@ -27,8 +26,7 @@
   end
 
   scenario "there is no more MMRV stock available" do
-    given_mmrv_vaccinations_are_enabled
-    and_i_am_signed_in_as_a_nurse
+    given_i_am_signed_in_as_a_nurse
     and_a_patient_exists
 
     when_i_visit_the_patient_mmrv_tab
@@ -40,11 +38,7 @@
     then_i_see_a_message_that_the_consent_is_successful
   end
 
-  def given_mmrv_vaccinations_are_enabled
-    Flipper.enable(:mmrv)
-  end
-
-  def and_i_am_signed_in_as_a_nurse
+  def given_i_am_signed_in_as_a_nurse
     @programme = Programme.mmr
     @team = create(:team, :with_one_nurse, programmes: [@programme])
 

spec/features/triage_without_gelatine_spec.rb

@@ -74,7 +74,7 @@ def when_i_go_to_the_patients_tab
 
   def then_i_see_the_patient
     expect(page).to have_content(@patient.full_name)
-    expect(page).to have_content("MMRNeeds triage")
+    expect(page).to have_content("MMRVNeeds triage")
   end
 
   def when_i_click_on_the_patient
@@ -105,12 +105,12 @@ def when_i_record_the_triage_outcome(without_gelatine:)
   end
 
   def then_i_see_the_triage_status_with_gelatine
-    expect(page).to have_content("MMR: Safe to vaccinate")
+    expect(page).to have_content("MMRV: Safe to vaccinate")
   end
 
   def then_i_see_the_triage_status_without_gelatine
     expect(page).to have_content(
-      "MMR: Safe to vaccinate with gelatine-free injection"
+      "MMRV: Safe to vaccinate with gelatine-free injection"
     )
   end
 end

spec/lib/reports/offline_session_exporter_spec.rb

@@ -121,14 +121,12 @@ def validation_formula(worksheet:, column_name:, row: 1)
           create(:batch, :not_expired, vaccine: programme.vaccines.active.first)
         end
         let(:patient_location) { create(:patient_location, patient:, session:) }
-        let(:patient) do
-          create(:patient, year_group: programme.default_year_groups.first)
-        end
+        let(:patient) { create(:patient, year_group:) }
 
         it { should be_empty }
 
         context "with a patient without an outcome" do
-          let!(:patient) { create(:patient, session:) }
+          let!(:patient) { create(:patient, session:, year_group:) }
 
           it "adds a row to fill in" do
             expect(rows.count).to eq(1)
@@ -228,7 +226,12 @@ def validation_formula(worksheet:, column_name:, row: 1)
 
         context "with a triage assessment" do
           let!(:patient) do
-            create(:patient, :consent_given_triage_safe_to_vaccinate, session:)
+            create(
+              :patient,
+              :consent_given_triage_safe_to_vaccinate,
+              session:,
+              year_group:
+            )
           end
 
           it "adds a row with the triage details" do
@@ -838,7 +841,7 @@ def validation_formula(worksheet:, column_name:, row: 1)
         it { should be_empty }
 
         context "with a patient without an outcome" do
-          let!(:patient) { create(:patient, session:) }
+          let!(:patient) { create(:patient, session:, year_group:) }
 
           it "adds a row to fill in" do
             expect(rows.count).to eq(1)
@@ -894,7 +897,7 @@ def validation_formula(worksheet:, column_name:, row: 1)
           let(:patient) do
             create(
               :patient,
-              year_group: programme.default_year_groups.first,
+              year_group:,
               school: create(:school, urn: "123456", name: "Waterloo Road")
             )
           end
@@ -1087,6 +1090,8 @@ def validation_formula(worksheet:, column_name:, row: 1)
 
   context "Flu programme" do
     let(:programme) { Programme.flu }
+    let(:year_group) { 6 }
+
     let(:expected_programme) { "Flu" }
     let(:expected_dose_sequence) { 1 }
     let(:expected_consent_status) do
@@ -1103,7 +1108,8 @@ def validation_formula(worksheet:, column_name:, row: 1)
         create(
           :patient,
           :consent_given_nasal_triage_safe_to_vaccinate_nasal,
-          session:
+          session:,
+          year_group:
         )
       end
       let(:workbook) { RubyXL::Parser.parse_buffer(call) }
@@ -1121,6 +1127,8 @@ def validation_formula(worksheet:, column_name:, row: 1)
 
   context "HPV programme" do
     let(:programme) { Programme.hpv }
+    let(:year_group) { 8 }
+
     let(:expected_programme) { "HPV" }
     let(:expected_dose_sequence) { 1 }
     let(:expected_consent_status) { "Consent given" }
@@ -1130,6 +1138,8 @@ def validation_formula(worksheet:, column_name:, row: 1)
 
   context "MenACWY programme" do
     let(:programme) { Programme.menacwy }
+    let(:year_group) { 9 }
+
     let(:expected_programme) { "ACWYX4" }
     let(:expected_dose_sequence) { nil }
     let(:expected_consent_status) { "Consent given" }
@@ -1139,6 +1149,8 @@ def validation_formula(worksheet:, column_name:, row: 1)
 
   context "MMR programme" do
     let(:programme) { Programme.mmr }
+    let(:year_group) { 11 }
+
     let(:expected_programme) { "MMR" }
     let(:expected_dose_sequence) { nil }
     let(:expected_consent_status) { "Consent given" }
@@ -1147,16 +1159,9 @@ def validation_formula(worksheet:, column_name:, row: 1)
   end
 
   context "MMRV programme" do
-    # We move forward in to the future where we can assume that MMRV is given
-    # to more children, this also ensures that the patients have a date of
-    # birth that makes them eligible.
-
-    before do
-      Flipper.enable(:mmrv)
-      travel 10.years
-    end
-
     let(:programme) { Programme.mmr }
+    let(:year_group) { 0 }
+
     let(:expected_programme) { "MMRV" }
     let(:expected_dose_sequence) { nil }
     let(:expected_consent_status) { "Consent given" }
@@ -1166,6 +1171,8 @@ def validation_formula(worksheet:, column_name:, row: 1)
 
   context "Td/IPV programme" do
     let(:programme) { Programme.td_ipv }
+    let(:year_group) { 9 }
+
     let(:expected_programme) { "3-in-1" }
     let(:expected_dose_sequence) { nil }
     let(:expected_consent_status) { "Consent given" }