Make Elnode work on Emacs 26.1 #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elnode doesn't work on Emacs 26.1, because it disallows both the `:nowait` and `:server` parameters. Add a cautious fix for this, which flips `:nowait` to nil when Emacs is on 26.1 upwards. This is the same method used by `emacs-http-server` to fix the same bug. Initial fix: eschulte/emacs-web-server#9 26.1-only patch: eschulte/emacs-web-server@cafa5b7
This was referenced Jun 1, 2019
Author
|
Closing due to MELPA updating their recipe: melpa/melpa#6184 Active fork here: https://github.com/jcaw/elnode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elnode doesn't work on Emacs 26.1, because in
make-network-process,:nowaitand:servercan no longer be true simultaneously. Add a cautious fix for this, which flips:nowaitto nilon Emacs 26.1 upwards.
This fix should be safe. It's the same method used by
emacs-web-serverto fix the same bug. Digging around, Emacs 25 ignores:nowaitwhen server itt. Emacs 26.1 just formalises this, by throwing an error.Fixes #106
Closes #105
Initially I thought Emacs 25.1+ was broken, but it looks like this isn't the case - it seems to be exclusive to Emacs 26.1+.