Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Build Action warns "Scheduled Sync and Build Disabled" with incorrect information #387

Open
hummelstrand opened this issue Aug 19, 2024 · 8 comments
Labels
bug Something isn't working needs-triage

Comments

@hummelstrand
Copy link

hummelstrand commented Aug 19, 2024

Describe the bug

When building with action number 4, I get a warning that says "...please follow the instructions under the following path Trio/fastlane/testflight.md" but the path seems to be https://github.com/nightscout/Trio/blob/main/fastlane/testflight.md

Expected behavior

If the warning is relevant, the path information should be updated, and possible hot linked.

Screenshots

image

Setup Information (please complete the following information):

Trio Version:

@hummelstrand hummelstrand added bug Something isn't working needs-triage labels Aug 19, 2024
@hummelstrand
Copy link
Author

Edited to update with what seems to be the correct path to the markdown file.

@marionbarker
Copy link
Contributor

Trio does have a fastlane folder and testflight.md is in the folder. My memory is that the error message is not a link, but instructions in how to navigate the user’s fork to find the file.

It is deliberate not to point to the docs because those links are subject to change.

If it is a link, then it should be updated.

@hummelstrand
Copy link
Author

@marionbarker The warning says "...under the following path Trio/fastlane/testflight.md" i.e. https://github.com/nightscout/Trio/fastlane/testflight.md which results in a 404, since the actual path is Trio/blob/main/fastlane/testflight.md i.e. https://github.com/nightscout/Trio/blob/main/fastlane/testflight.md

@bjornoleh
Copy link
Contributor

Sorry for being slightly off topic, but is this info correct? I thought scheduled sync and build was on by default for Trio and also Loop, and that disabling one or both are options? That’s how I read the testflight.md too.

@marionbarker
Copy link
Contributor

If workflow is not enabled for GH_PAT, it is disabled.

@bjornoleh
Copy link
Contributor

bjornoleh commented Aug 19, 2024

Ok, thanks. I would expect users to follow the instructions and enable the workflow scope, but this probably happens for users that skip that step based on this:

Create GitHub Personal Access Token

If you have previously built another app using the "browser build" method, you use the same personal access token (GH_PAT), so skip this step.

Copy link

hey 👋 - no triage is done for 30 days 🤐 ... anybody? triage is required!

@github-actions github-actions bot added the stale label Sep 19, 2024
@dnzxy
Copy link
Contributor

dnzxy commented Oct 18, 2024

It‘s the correct path in the repository folder structure, not the actual link path.

If you look at the repository as a big project folder, you will have to go into root/fastlane/testflight.md. It’s not a path as in link-path.

image

This is not really an issue/bug. Marion has provided the correct explanation, too. It is not a link, it is the folder path in the repository.

This is also how it was accepted into LoopWorkspace. It’s deliberately phrased like that and does not point at any documentation page.

@github-actions github-actions bot removed the stale label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
Status: No status
Development

No branches or pull requests

4 participants