From a707028cdc50efe192befb59b9e74bcb571efbf2 Mon Sep 17 00:00:00 2001
From: David Mello <theycallmedavidmello@gmail.com>
Date: Thu, 17 Mar 2022 11:49:19 -0400
Subject: [PATCH 1/2] Replaced rm -rf with rimraf command in clean script for
better cross-platform compatibility with Windows
---
package-lock.json | 3 ++-
package.json | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/package-lock.json b/package-lock.json
index 75ad441..347d9c1 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -18,7 +18,8 @@
"@typescript-eslint/parser": "^5.14.0",
"chromedriver": "^99.0.0",
"eslint": "^8.10.0",
- "geckodriver": "^3.0.1"
+ "geckodriver": "^3.0.1",
+ "rimraf": "^3.0.2"
}
},
"node_modules/@eslint/eslintrc": {
diff --git a/package.json b/package.json
index aa000b4..8756a8a 100644
--- a/package.json
+++ b/package.json
@@ -4,7 +4,7 @@
"description": "Boilerplate code for running Nightwatch tests in TypeScript",
"main": "index.js",
"scripts": {
- "clean": "rm -rf dist logs tests_output",
+ "clean": "rimraf dist logs tests_output",
"build": "tsc",
"clean:build": "npm run clean && npm run build",
"test": "npm run clean && tsc && nightwatch --env chrome",
@@ -32,7 +32,8 @@
"@typescript-eslint/parser": "^5.14.0",
"chromedriver": "^99.0.0",
"eslint": "^8.10.0",
- "geckodriver": "^3.0.1"
+ "geckodriver": "^3.0.1",
+ "rimraf": "^3.0.2"
},
"dependencies": {
"@types/nightwatch": "^2.0.1",
From 726c1eed39bab51a6af2a90276d75c14f2bfb505 Mon Sep 17 00:00:00 2001
From: David Mello <theycallmedavidmello@gmail.com>
Date: Thu, 17 Mar 2022 12:41:20 -0400
Subject: [PATCH 2/2] Possibly fixed an issue with github checks running rimraf
without knowing the explicit node_modules location of bin.js
---
package.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package.json b/package.json
index 8756a8a..b4b7b13 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,8 @@
"test": "npm run clean && tsc && nightwatch --env chrome",
"test-browserstack": "npm run clean && tsc && nightwatch --env browserstack.chrome",
"lint": "eslint . --ext .ts",
- "lint-and-fix": "eslint . --ext .ts --fix"
+ "lint-and-fix": "eslint . --ext .ts --fix",
+ "rimraf": "./node_modules/rimraf/bin.js"
},
"repository": {
"type": "git",