Revert adding generic V: Ordinal parameter to succ, pred, inc, dec

[konsumlamm]

This was added in #20829, however it wasn't mentioned anywhere. Provided this passes the CI, I don't see why this was changed in the first place. I don't think it makes sense to add/subtract arbitrary Ordinals (which is what succ/pred currently allow). It also makes codegen more complicated (at least for JS, which is currently broken because of this, I haven't checked for C/C++), since now we can't rely on the second argument being an int anymore.

cc @bung87

[konsumlamm]

For some reason I get an assertion failure for the runnableExamples in default, which seems to be unrelated:

proc default*[T](_: typedesc[T]): T {.magic: "Default", noSideEffect.} =
  ## Returns the default value of the type `T`. Contrary to `zeroDefault`, it takes default fields
  ## of an object into consideration.
  ##
  ## See also:
  ## * `zeroDefault <#zeroDefault,typedesc[T]>`_
  ##
  runnableExamples:
    assert (int, float).default == (0, 0.0)
    type Foo = object
      a: range[2..6]
    var x = Foo.default
    assert x.a == 2

On my fork, the CI doesn't fail.

[konsumlamm]

Ok, so this change causes default(range[2..6]) to be 0 instead of 2, I'll try to figure out why.

[ringabout]

Ok, so this change causes default(range[2..6]) to be 0 instead of 2, I'll try to figure out why.

It's unrelated. Fixed by #22331

[konsumlamm]

The CI failure seems to be unrelated.

[bung87]

just curious, is it suitable change these int32 to int?

[konsumlamm]

just curious, is it suitable change these int32 to int?

Yes, trailingZeros2Digits always returns 0, 1, or 2 and tz and nd are always smaller than 30.

[github-actions]

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from e15e193

Hint: mm: orc; opt: speed; options: -d:release
168493 lines; 8.687s; 611.668MiB peakmem

[Araq]

Since this breaks our own checksums package this needs to be reverted.