Skip to content

Restore sink annotations in the standard library where sensible #1597

@zerbina

Description

@zerbina

Summary

With #1595, automatic sink inference was removed, which does affect some parts of the system and standard libraries. Where sensible, sink annotations should be added/used manually.

How

While it's possible to go through the modules manually (the ones including inclrtl are affected), it's likely easier to temporarily restore the sink inference logic but with modifying the type replaced with echoing the source location of the parameter.

Note that sink inference was somewhat eager (a parameter being used in a sink position was enough to turn the parameter into a sink parameter), meaning that not all the inferences it made were good.

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard library

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions