fix terminal expression used as construction operand #1643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix using a terminal expressions as an object construction operand
resulting in incorrect run-time behaviour.
Details
Elimination of unreachable expression didn't handle object constructors
properly, not adding the terminal expression to the resulting statement
list. For example:
Since the surrounding statement was marked as not returning, the lack
of terminator statement caused incorrect MIR to be produced by
mirgen
.The terminal expression is now added to the produced statement list,
and a test is added to make sure eliminating construction expressions
works.