Skip to content

Commit db8238c

Browse files
[#493] Update code according to PR comment for template_review_pull_request.yml
1 parent 2a358de commit db8238c

File tree

2 files changed

+2
-20
lines changed

2 files changed

+2
-20
lines changed

.github/workflows/review_pull_request.yml

+1-10
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ jobs:
5353
uses: ruby/setup-ruby@v1
5454
with:
5555
ruby-version: '2.7'
56+
bundler-cache: true
5657

5758
- name: Cache gems
5859
uses: actions/cache@v2
@@ -62,16 +63,6 @@ jobs:
6263
restore-keys: |
6364
${{ runner.os }}-gems-
6465
65-
- name: Install Bundle and check environment versions
66-
run: |
67-
echo 'Install Bundle'
68-
bundle config path vendor/bundle
69-
bundle install
70-
echo 'Check environment setup versions'
71-
ruby --version
72-
gem --version
73-
bundler --version
74-
7566
- name: Run Danger
7667
env:
7768
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

template-compose/.github/workflows/review_pull_request.yml renamed to template-compose/.github/workflows/template_review_pull_request.yml

+1-10
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
if: github.event.pull_request.draft == false
1414
name: Review pull request
1515
runs-on: ubuntu-latest
16-
environment: dev
16+
environment: staging
1717
timeout-minutes: 30
1818
steps:
1919
- name: Checkout source code
@@ -38,15 +38,6 @@ jobs:
3838
distribution: 'temurin'
3939
java-version: '17'
4040

41-
- name: Run Detekt
42-
run: ./gradlew detekt
43-
44-
- name: Run Android Lint
45-
run: ./gradlew lintDevDebug
46-
47-
- name: Run unit tests with Kover
48-
run: ./gradlew koverXmlReport
49-
5041
- name: Set up Ruby
5142
uses: ruby/setup-ruby@v1
5243
with:

0 commit comments

Comments
 (0)