Skip to content

Non-blocking termination ends playback #5

@jaggzh

Description

@jaggzh

I'm not sure how others didn't experience this issue -- perhaps something weird with threading.

    wave_out = output[0] if isinstance(output, tuple) else output
    if play: play_wave(wave_out, blocking=True, sr=tts.sr)
    if save_to is not None:
        save_wave(wave_out, save_to, sample_rate=tts.sr, 
                  bits_per_sample=bits_per_sample)

My output was terminating too soon during playback. Maybe others threads continue until it was done?

https://github.com/jaggzh/tts_arabic/blob/main/tts_arabic/models/core.py#L134

I can go ahead and do a PR for your review. I think I have the disabling of the download time test in there too though.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions