Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review NMIND Checklist submitted and provide corrections if desired #1362

Open
8 tasks
LuciMoore opened this issue Nov 22, 2024 · 0 comments
Open
8 tasks

Review NMIND Checklist submitted and provide corrections if desired #1362

LuciMoore opened this issue Nov 22, 2024 · 0 comments

Comments

@LuciMoore
Copy link

What would you like to see added in this software?

I've submitted an NMIND checklist for MRIQC here and it is waiting for final review by the NMIND team in order to be added to the NMIND list of Evaluated Tools. This was done as part of the software & analytic standards outlined for pipelines/tools utilized for the HBCD data release and the tools are expected to undergo final review and approval by Dec 10th.

Please feel free to review the checklist and let me know if you feel I've missed anything. You can view the checklist by creating a file copy of the json posted to the issue and importing it into the checklist by clicking IMPORT JSON at the bottom of the checklist page. If you noticed that I missed something, you can either revise the checklist json within the issue or just let me know directly which items should be checked as complete

For quick reference, I determined that all checklist items were complete except the following:

Gold Badge checklist items for Documentation:

  • Continuous integration badges in README for coverage
  • Maintenance status is documented
    (e.g., expected turnaround time on pull requests, whether project is maintained)

Bronze, Silver, and Gold Checklists items for Testing:

Bronze:

  • Provide / generate / point to test data

  • Provide instructions for users to run tests that include instructions for evaluation for correct behavior

Silver:

  • Some form of testing suite present
  • Test coverage > 50%

Gold:

  • Test coverage > 90%
  • Benchmarking information is provided for examples

I've posted this issue for your general awareness just in case you wanted to review the checklist for errors (although these will likely be caught by the final NMIND review as well), you can close it whenever you would like. Thank you!

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant