Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better summary composition scheme for multiple API function calls #103

Open
nischalshrestha opened this issue Dec 23, 2021 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@nischalshrestha
Copy link
Owner

nischalshrestha commented Dec 23, 2021

Description

Often times, R code (especially tidyverse) will have nested functions being called. For example, here:

mtcars %>%
  names() %>%
  map(~count(mtcars, .data[[.x]]))

the map function call also has a count function call as part of the lambda function to apply to each of the names(). This means that we can have potentially a 'nesting' of summaries where the inner function call (count()) summary needs to be somehow incorporated with the outer (map()).

Currently, the tidylog side and the way we've cached summaries to access them (instead of display()'ing) prevents us from stitching the two summaries together. Instead, the count summary overwrites the map since map also does not have summary support yet (issue #97).

We need a more principled approach to gather summaries such that we can capture--to start--the API function call summaries and unify them into one summary for the most outermost function.

@nischalshrestha nischalshrestha added the enhancement New feature or request label Dec 23, 2021
@nischalshrestha nischalshrestha added the bug Something isn't working label Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant