Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hercules-effects support #115

Open
Mic92 opened this issue Apr 6, 2024 · 3 comments
Open

Hercules-effects support #115

Mic92 opened this issue Apr 6, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@Mic92
Copy link
Member

Mic92 commented Apr 6, 2024

Started in #68

@zimbatm zimbatm added this to the Release 1.0 milestone Jun 11, 2024
@zimbatm zimbatm added the enhancement New feature or request label Jun 11, 2024
@zowoq
Copy link
Contributor

zowoq commented Aug 3, 2024

@Mic92 How you you plan to handle secrets? Separate secrets file for each repo or just one secret file per instance like hercules?

@Mic92
Copy link
Member Author

Mic92 commented Aug 3, 2024

Ideally one per repository if I can make it secure. Maybe each repository gets a public key for encryption.

@zowoq
Copy link
Contributor

zowoq commented Oct 15, 2024

I forgot to ask about the GitToken secret, it is a short lived token from the github app set by the hercules backend.

Possible that some repos may not even need to set secrets if they had this token as it could be used for pushing to the repo, pages, releases, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants