Skip to content

refactor: reuse disko inside disko-install #1073

Open
@midischwarz12

Description

@midischwarz12

Description

Refactor the disko-install cli tool so that it uses the disko cli tool within it.

Motivation

Currently, much of the logic in disko and disko-install, and in cli.nix and install-cli.nix is shared and/or duplicate. In the spirit of code reuse, I think much of this should be refactored. Any additional features for the disko cli would likely have to implemented again for disko-install. Also, there could be unforseen bugs since they have diverged with very different implementations. It's usually a best practice to reuse code when possible because of this.

Proposal

Move much of the code from disko-install and install-cli.nix over to disko and cli.nix. And after, have disko-install run disko from within it. Keep everything beyond just disko to install and such within disko-install. Anything that is required for nixos-install such as mounting with filesystem options and boot options then get separated into a separate install.nix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions