Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and check formatting in CI #854

Open
iFreilicht opened this issue Oct 28, 2024 · 1 comment
Open

Lint and check formatting in CI #854

iFreilicht opened this issue Oct 28, 2024 · 1 comment
Labels
testing Missing or incorrect tests

Comments

@iFreilicht
Copy link
Contributor

Thanks to #716, we can very easily verify whether a PR has been properly formatted. But we're not doing it, yet. We would have to checkout the branch and run nix fmt -- --check manually.

Add a check to our CI to do this.

@iFreilicht iFreilicht added the testing Missing or incorrect tests label Oct 28, 2024
@Mic92
Copy link
Member

Mic92 commented Oct 29, 2024

In nixos-facter-modules we were able to include flakes for devshell/checks only:
https://github.com/numtide/nixos-facter-modules/blob/main/flake.nix

Given that all those flake follows are a bit annoying for end-users it might be worth the effort in project also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Missing or incorrect tests
Projects
None yet
Development

No branches or pull requests

2 participants