You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to open a conversation about improving the UX when writing/fixing tests.
Basically while setting up tests I found myself running namaka check || namaka review as part of my feedback loop just to get a diff. That could easily be twice as fast by avoiding either evaluation.
Also since I was just wanting to see diffs, not update the snapshots, I had to do Ctrl-C in addition to "up + return" every time. And this isn't something I'm looking to improve here, but exiting in the middle of a prompt partially breaks the terminal because of console-rs/dialoguer#248, which adds a bit of frustration to that flow.
The first solution that comes to mind is adding something like check --verbose/--show-diffs or review --check.
But I'd even say both commands could be merged. You might have a flow in mind that I don't but based on my current understanding, having check print the diff by default seems to only have upsides.
And from there maybe also make check prompt by default if isatty(stdin), with a way to opt-out via something like --no-prompt/--non-interactive.
Then since check also has review's functionality review could be removed/made an alias, and the complexity surrounding .pending can be removed.
Again, thanks for the tool, I like it and this is coming from a positive place: trying make the UX even better :)
The text was updated successfully, but these errors were encountered:
I want to open a conversation about improving the UX when writing/fixing tests.
Basically while setting up tests I found myself running
namaka check || namaka review
as part of my feedback loop just to get a diff. That could easily be twice as fast by avoiding either evaluation.Also since I was just wanting to see diffs, not update the snapshots, I had to do Ctrl-C in addition to "up + return" every time. And this isn't something I'm looking to improve here, but exiting in the middle of a prompt partially breaks the terminal because of console-rs/dialoguer#248, which adds a bit of frustration to that flow.
The first solution that comes to mind is adding something like
check --verbose/--show-diffs
orreview --check
.But I'd even say both commands could be merged. You might have a flow in mind that I don't but based on my current understanding, having
check
print the diff by default seems to only have upsides.And from there maybe also make
check
prompt by default ifisatty(stdin)
, with a way to opt-out via something like--no-prompt
/--non-interactive
.Then since
check
also hasreview
's functionalityreview
could be removed/made an alias, and the complexity surrounding.pending
can be removed.Again, thanks for the tool, I like it and this is coming from a positive place: trying make the UX even better :)
The text was updated successfully, but these errors were encountered: