Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Potential check and review flow improvments #126

Open
ThinkChaos opened this issue Dec 21, 2023 · 2 comments
Open

[UX] Potential check and review flow improvments #126

ThinkChaos opened this issue Dec 21, 2023 · 2 comments

Comments

@ThinkChaos
Copy link

ThinkChaos commented Dec 21, 2023

I want to open a conversation about improving the UX when writing/fixing tests.

Basically while setting up tests I found myself running namaka check || namaka review as part of my feedback loop just to get a diff. That could easily be twice as fast by avoiding either evaluation.
Also since I was just wanting to see diffs, not update the snapshots, I had to do Ctrl-C in addition to "up + return" every time. And this isn't something I'm looking to improve here, but exiting in the middle of a prompt partially breaks the terminal because of console-rs/dialoguer#248, which adds a bit of frustration to that flow.

The first solution that comes to mind is adding something like check --verbose/--show-diffs or review --check.
But I'd even say both commands could be merged. You might have a flow in mind that I don't but based on my current understanding, having check print the diff by default seems to only have upsides.
And from there maybe also make check prompt by default if isatty(stdin), with a way to opt-out via something like --no-prompt/--non-interactive.
Then since check also has review's functionality review could be removed/made an alias, and the complexity surrounding .pending can be removed.

Again, thanks for the tool, I like it and this is coming from a positive place: trying make the UX even better :)

@figsoda
Copy link
Member

figsoda commented Nov 14, 2024

thanks for the feedback, I will get through the rest of it when I get time

exiting in the middle of a prompt partially breaks the terminal because of console-rs/dialoguer#248

could you test if #180 fixes the issue for you?

@ThinkChaos
Copy link
Author

Are you interested in contributions and have time for reviews?
If so what do you think of merging review into check? That's something I could tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants