Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOTICE] Upstream breaking changes #533

Closed
willruggiano opened this issue May 26, 2024 · 7 comments
Closed

[NOTICE] Upstream breaking changes #533

willruggiano opened this issue May 26, 2024 · 7 comments

Comments

@willruggiano
Copy link
Contributor

willruggiano commented May 26, 2024

If you've recently updated your system to depend on a recent commit (at least d659352) of this repository, you might encounter an error like that seen in #521. If you do, ensure that you have a recent nixpkgs package set (at least NixOS/nixpkgs@d5786c1).

There were a number of commits introduced upstream (i.e. nixpkgs) where breaking changes (and subsequent reverts) were made to the packaging of neovim-unwrapped (particularly as it relates to bundling tree-sitter parsers), for example; NixOS/nixpkgs@76ef4c7.

This advice applies particularly to those of you which override the nixpkgs input for this flake, e.g.

inputs.neovim-nightly-overlay.inputs.nixpkgs.follows = "your nixpkgs";

as well as those of you that use the flake's default overlay, e.g.

{
  nixpkgs.overlays = [
    inputs.neovim-nightly-overlay.overlays.default
  ];
}
@willruggiano willruggiano pinned this issue May 26, 2024
@willruggiano willruggiano changed the title [BREAKING CHANGE] neovim-nightly-overlay depends on nixpkgs commit [NOTICE] Upstream breaking changes May 26, 2024
@TeleVoyant
Copy link

aarrg, now i'm sarge. any propositions to go around this?

@Bot-wxt1221

This comment was marked as resolved.

@GaetanLepage
Copy link
Member

@willruggiano should we know mark this as resolved ?

@willruggiano
Copy link
Contributor Author

I would keep it open for a bit longer. There's been a few references to it recently

@GaetanLepage
Copy link
Member

I would keep it open for a bit longer. There's been a few references to it recently

Sure !

WilliamHsieh added a commit to WilliamHsieh/dotfiles that referenced this issue Jul 26, 2024
note: nixpkgs upsteam currently contains breaking changes, causing neovim failed to build on stable branch
ref: nix-community/neovim-nightly-overlay#533
ref: sandydoo/nixos@261ff27
@matejc
Copy link

matejc commented Oct 17, 2024

I am unsure if this is the same issue, but I get

error:
       … while calling the 'head' builtin

         at /nix/store/mj0rlzph9xh8x3jj8bq4rqn0zql15w68-source/lib/attrsets.nix:1575:11:

         1574|         || pred here (elemAt values 1) (head values) then
         1575|           head values
             |           ^
         1576|         else

       … while evaluating the attribute 'value'

         at /nix/store/mj0rlzph9xh8x3jj8bq4rqn0zql15w68-source/lib/modules.nix:816:9:

          815|     in warnDeprecation opt //
          816|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          817|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'unwrapped' missing

       at /nix/store/mj0rlzph9xh8x3jj8bq4rqn0zql15w68-source/pkgs/by-name/ne/neovim-qt-unwrapped/package.nix:22:5:

           21|   buildInputs = [
           22|     neovim.unwrapped # only used to generate help tags at build time
             |     ^
           23|     libsForQt5.qtbase

while using this flake's nixpkgs

@willruggiano
Copy link
Contributor Author

Hard to tell without seeing how you're using the flake. It looks like you're trying to install neovim-qt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants