Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To many things are colored blue #40

Open
SuperSandro2000 opened this issue Jun 22, 2023 · 1 comment
Open

To many things are colored blue #40

SuperSandro2000 opened this issue Jun 22, 2023 · 1 comment

Comments

@SuperSandro2000
Copy link
Member

Github rolled out a change to this tree-sitter grammar yesterday and since that the highlighting of nix files is mostly shades of blue eg https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/hello/default.nix

I think before at least attr keys where colored yellow and there were probably some other differences I can't recall right now.

I think we should compare color coding with the grammar github used before https://github.com/sambacha/nix-linguist to make this one a bit more colorful and helpful to the eye.
@SuperSandro2000 SuperSandro2000 mentioned this issue Jun 22, 2023
Merged
1 task
@Artturin
Copy link
Member

Artturin commented Jun 22, 2023 •
edited
Loading

NixOS/nixpkgs#135678 (comment)
Old ss 2021-11-18
nixpkgs_issue_135678__screenshot_2021-11-18_02-31-05_713306253

New ss
nixpkgs_issue_135678__screenshot_2023-06-22_14-05-02_185063717

https://github.com/NixOS/nixpkgs/pull/227970/files
Old ss 2023-04-28
nixpkgs_issue___screenshot_2023-04-28_16-16-35_823631142

New ss
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SuperSandro2000 @Artturin