Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify NLTK data directory in Dockerfile and add build test #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Specify NLTK data directory in Dockerfile and add build test #86

wants to merge 2 commits into from

Conversation

jinkjonks
Copy link
Contributor

@jinkjonks jinkjonks commented Aug 9, 2024 •
edited
Loading

Description of the change

  • Specify NLTK data directory in Dockerfile when running downloaders for punkt and stopwords.
  • add a docker build smoke test (sleep at 20s because that seems to be how long it takes to boot up the jar)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@jinkjonks jinkjonks force-pushed the nltk-dir branch 4 times, most recently from 04d8c21 to 9c1909b Compare August 9, 2024 04:06
@jinkjonks
Copy link
Contributor Author

@ansukla @kiran-nlmatics Please review, thanks!

@jinkjonks jinkjonks changed the title Specify NLTK data directory in Dockerfile Specify NLTK data directory in Dockerfile and add build test Aug 9, 2024
@jinkjonks jinkjonks mentioned this pull request Aug 9, 2024
Open
@jinkjonks
Copy link
Contributor Author

Hey @jamesvillarrubia, I've noticed that you've been somewhat active. Can you please take a look at merging this? Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NLTK Data directory not found
1 participant
@jinkjonks