Pull Request Approval Guideline/Practice

[LucaFue]

Hello!

I got a question regarding the current practices/guidelines for PR approvals. There are PRs that have been approved before merge (e.g. #4802) and PRs that have not been approved before merge (e.g. #4803).

What is the current general practice here? Do PRs only need to be approved when there are more substantial changes?

Thanks!

[nlohmann]

It would be great to have reviewers for all PRs, but realistically, this would mean that a lot of my PRs would be pending for quite a while. For the most important things, however, I wait as long as necessary to get a review.

That's for my PRs. I review everything from others though.

[LucaFue]

Alright, thanks for clarification!