Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View codes and logic codes should not be coupled #10

Open
cychiuae opened this issue Dec 3, 2016 · 1 comment
Open

View codes and logic codes should not be coupled #10

cychiuae opened this issue Dec 3, 2016 · 1 comment

Comments

@cychiuae
Copy link

cychiuae commented Dec 3, 2016

The codes for fetching post should be separated from component codes
@jackytck
Copy link

jackytck commented Dec 6, 2016

Yes, e.g. in Thread.js, it should be pure and should not reloadPosts by itself. It should dispatch an action to reload posts, then await the result in redux-thunk, ... etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackytck @cychiuae