New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle non-identifier exports #7

Open

bmeck opened this issue Dec 2, 2021 · 0 comments

Labels

wasm

Member

bmeck commented Dec 2, 2021

Due to WASM and https://github.com/bmeck/proposal-arbitrary-module-namespace-identifiers JS can export names that are not identifiers, this generally only affects WASM though

See potential fix by using index rather than name like in https://github.com/nodejs/node/blob/255b1db9320df7b2e17a248ba4ab659d3f25853d/test/fixtures/es-module-loaders/mock-loader.mjs#L232

bengl added the wasm label

timfish mentioned this issue

fix: Skip wrapping CJS modules which result in invalid identifiers #115

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment