Skip to content

Mixed content html/img/iframe galleries don't use the correct filter type #421

@chris-twiner

Description

@chris-twiner

What kind of issue is this? (put 'x' between the square brackets)

Inserting the following to featherlight.js line 227:

if (data === '' && !filter) {
  var typeValue = readTargetAttr('data-featherlight-type');
  data = typeValue || '';
}

allows attributes to use the data-featherlight-type to bind when directly clicked the correct type and during gallery navigation when started from another 'slide'. Noticeable in the case of this attribute being iframe as ajax is the default contentFilter it will load the entire iframe page and insert the elements directly instead of an iframe when navigated to.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions