- Roll out reviewer feedback to other files too

- Apply ruff linting

Changes to be committed:
	modified:   src/nomad_simulations/schema_packages/atoms_state.py
	modified:   src/nomad_simulations/schema_packages/model_method.py
	modified:   src/nomad_simulations/schema_packages/model_system.py

Author: ndaelman-hu

src/nomad_simulations/schema_packages/atoms_state.py

@@ -1,7 +1,7 @@
-from typing import TYPE_CHECKING
-
 from abc import abstractmethod
 from functools import cached_property
+from typing import TYPE_CHECKING
+
 import ase
 import numpy as np
 import pint

src/nomad_simulations/schema_packages/model_method.py

@@ -495,7 +495,7 @@ def resolve_orbital_references(
         try:
             model_system = model_systems[model_index]
         except IndexError:
-            logger.warning(f'No ModelSystem at index {model_index}.')
+            logger.warning('No ModelSystem at index %s.', model_index)
             return None
 
         # If the system is not representative, bail out of normalization
@@ -534,15 +534,15 @@ def resolve_orbital_references(
             for idx in child_sys.particle_indices:
                 if idx < 0 or idx >= len(model_system.particle_states):
                     logger.warning(
-                        f'Particle index {idx} out of range for particle_states.'
+                        'Particle index %s out of range for particle_states.', idx
                     )
                     continue
                 active_atom_state = model_system.particle_states[idx]
 
                 # If no orbitals_state => skip
                 if not active_atom_state.electronic_state:
                     logger.warning(
-                        f'No electronic_state found in particle_states[{idx}].'
+                        'No electronic_state found in particle_states[%s].', idx
                     )
                     continue
 

src/nomad_simulations/schema_packages/model_system.py

@@ -533,7 +533,7 @@ def resolve_analyzed_atomic_cell(
 
         mapping = cell_type_map.get(cell_type)
         if mapping is None:
-            logger.error(f'Cell type {cell_type} is not supported.')
+            logger.error('Cell type %s is not supported.', cell_type)
             return None
 
         try: