Skip to content

Commit 3d43526

Browse files
committed
Remove the prebuilt FE and the unit test
This PR is part of deprecating the FE. as a first step, this PR is cleaning the `lib.js` and the `lib.js.map` and also removing the fe test. The PR is also removing the entry of `built:fe` from the `package.json` Still remain TODO: - remove the FE code - remove the `clean:fe` from the package.json Signed-off-by: liranmauda <[email protected]>
1 parent eb5225f commit 3d43526

28 files changed

+79
-45293
lines changed

.dockerignore

-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
.git/
22
node_modules/
3-
frontend/node_modules/
4-
frontend/dist/
53
build/
64
coverage/
75
logs/

.github/workflows/frontend-unit.yml

-19
This file was deleted.

.travis.yml

-7
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,6 @@ matrix:
3434
- make tester ${NO_CACHE} ${SUPPRESS_LOGS} || exit 1
3535
- make test ${SUPPRESS_LOGS}
3636

37-
- language: generic
38-
39-
name: "Frontend Library Build Test"
40-
41-
script:
42-
- make verify-fe-lib
43-
4437
- language: node_js
4538
node_js:
4639
- "14"

CONTRIBUTING.md

+1-7
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ We're happy to get your input on the project. Please consider the following befo
1515
- Expected Behavior - What did you expect to happen
1616
- Steps to reproduce - How can the issue be reproduced so a fix can be verified
1717
- Add screenshots or log parts which can be helpful to investigate the issue
18-
- For issues related to the GUI (FE) please provide the FE dump package which can be obtained by
19-
- Reproduce the issue in your browser
20-
- Open dev tools and go to console
21-
- run nb.utils.dumpAppLog(), save the gz file and upload it as part of the bug
2218

2319
#### Issue Labels
2420
Issue labels are divided into several categories:
@@ -49,9 +45,7 @@ Issue labels are divided into several categories:
4945
---MISSING---
5046

5147
#### Coding Style
52-
The /src and the /frontend code trees have a different coding style.
53-
5448

5549
---MISSING---
5650

57-
You can run eslint to verify various coding style patterns (.eslintrc exists both in the project root and in the /frontend root)
51+
You can run eslint to verify various coding style patterns.

FE_PULL_REQUEST.md

-23
This file was deleted.

Makefile

-11
Original file line numberDiff line numberDiff line change
@@ -135,17 +135,6 @@ noobaa: base
135135
@echo "\033[1;32mNooBaa done.\033[0m"
136136
.PHONY: noobaa
137137

138-
verify-fe-lib: builder
139-
@echo "\033[1;Verifying Frontend Library $(CONTAINER_ENGINE) build.\033[0m"
140-
$(DOCKER_BUILDKIT) $(CONTAINER_ENGINE) build $(CPUSET) -f src/deploy/NVA_build/FrontendLib.Dockerfile $(CACHE_FLAG) $(NETWORK_FLAG) -t frontend-lib . $(REDIRECT_STDOUT)
141-
@echo "\033[1;32mFrontend Library build verified.\033[0m"
142-
.PHONY: verify-fe-lib
143-
144-
fe-test: base
145-
@echo "\033[1;34mRunning frontend tests.\033[0m"
146-
$(CONTAINER_ENGINE) run $(CPUSET) --name noobaa_$(GIT_COMMIT)_$(NAME_POSTFIX) noobaa-base npm run test --prefix ./frontend
147-
.PHONY: fe-test
148-
149138
# This rule builds a container image that includes developer tools
150139
# which allows to build and debug the project.
151140
nbdev:

SUPPORT.md

-3
This file was deleted.

frontend/src/lib/lib.js

-43,577
This file was deleted.

frontend/src/lib/lib.js.map

-1
This file was deleted.

0 commit comments

Comments
 (0)