Open
Description
Environment info
- NooBaa Version: 4.19
- Platform: NC
Actual behavior
- While debugging notifications + lifecycle, in an old version of NC lifecycle we used update_config_file() and we saw that on some failure the buckets config files were deleted, therefore we checked the code and saw that
it might be because of the next line -
await safe_unlink(fs_context, config_path, stat, undefined, tmp_dir_path);
we need to evaluate this code more and fix this potential issue.
Expected behavior
- config files can not be deleted as a result of a failure of update_config_file()
Steps to reproduce
- it's probably can be reproducible artificially when throwing an error after the safe_unlink()