NSFS | versioning | POSIX - safe_move validation fails if the mtime changes

[nadavMiz]

Environment info

• NooBaa Version: VERSION
• Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

on POSIX safe_move function we validate the mtime to the version-id. in case the mtime of the file was changed after it was created (and got a version-id): safe_move will fail on mismatch mtime. this will keep happening no matter how much we try to move because the version-id and mtime do no fit anymore. this may also be the case for the safe_unlink function.

see:
SafeMove, SafeUnlink in fs_nappi.cpp

Actual behavior

1.move fails with internal error

Expected behavior

1.move succeeds

Steps to reproduce

1. enable versioning:

s3api put-bucket-versioning --bucket test-bucket --versioning-configuration Status=Enabled

2. create a new object:

s3api put-object --bucket test-bucket --key key1

3. change mtime of the file:
   on linux:

touch -d "5 days ago" ${target_path}

on mac:

touch -t $(date -v -5d +"%Y%m%d%H%M.%S") ${target_path}

4. create a new object with the same key:

s3api put-object --bucket test-bucket --key key1

this will try to move the object to the .versions dir

More information - Screenshots / Logs / Other output

[shirady]

After fixing this, please consider removing the following note:

noobaa-core/src/test/unit_tests/jest_tests/test_nc_lifecycle_posix_integration.test.js

Line 1175 in 44d6518

* - Please do not use on versioned objects (version_id will not be changed, but the mtime will be changed) - might cause issues.