Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 5 directory structure does not match Java conventions #46

Open
MaskedBit opened this issue Oct 6, 2018 · 3 comments
Open

Chapter 5 directory structure does not match Java conventions #46

MaskedBit opened this issue Oct 6, 2018 · 3 comments

Comments

@MaskedBit
Copy link

The source files for chapter5 contain the package declaration "package nia.chapter5;". Maven and the Java compiler expect to find the sources on the path "chapter5/src/main/java/nia/chapter5". Unfortunately, the path on Github is "chapter5/src/main/java/nia.chapter5". I don't know about other IDEs, but the Maven plugin for eclipse is very unhappy with that.
laszlokiraly added a commit to laszlokiraly/netty-in-action that referenced this issue Nov 6, 2018
@laszlokiraly
fix normanmaurer#46 chapter 5 directory structure
c6b8c46
@byronzoz
Copy link

Yes, eclipse IDE has the problem above.

@songxinqiang
Copy link

i found the problem too

@duanzhenke
Copy link

Great gods, take me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MaskedBit @songxinqiang @byronzoz @duanzhenke