Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confused about file wrapper depends on protocol #53

Open
HYisen opened this issue Mar 16, 2020 · 0 comments
Open

confused about file wrapper depends on protocol #53

HYisen opened this issue Mar 16, 2020 · 0 comments

Comments

@HYisen
Copy link

HYisen commented Mar 16, 2020

if (ctx.pipeline().get(SslHandler.class) == null) {
ctx.write(new DefaultFileRegion(
file.getChannel(), 0, file.length()));
} else {
ctx.write(new ChunkedNioFile(file.getChannel()));
}

ctx.pipeline().get(SslHandler.class) == null checks whether HTTPS is enabled.
The difference between new DefaultFileRegion(file.getChannel(), 0, file.length()) and new ChunkedNioFile((file.getChannel())) is that the previous one would use zero-copy optimization, which is beneficial to performance if possible.
But how shall the protocol(TLS or not) determine the usage of optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant