Tick understanding

Author: Konstantin Kalinovsky

.gitignore

@@ -1,4 +1,3 @@
-# Created by .ignore support plugin (hsz.mobi)
 *.pyc
 *__pycache__*
 .cache/*

.gitmodules

@@ -1,15 +1,16 @@
-FROM python:3.6
+FROM python:3.6-slim
 
 LABEL maintainer="FAF Community"
-LABEL version="0.4.2"
+LABEL version="0.4.6"
 LABEL description="Forged Alliance Forever: Replay server"
 
-ENV PYTHON_VERSION 3.6.6
-ENV PYTHON_PIP_VERSION 18.0
-
 EXPOSE 15000
 
 COPY . /var/faf-aio-replayserver
-RUN pip3 install -r /var/faf-aio-replayserver/requirements.txt
+RUN apt-get update && apt-get install -y git && \
+    pip3 install pipenv && \
+    cd /var/faf-aio-replayserver && pipenv install --deploy --system && \
+    apt-get remove -y git libicu-dev libicu57 gcc-6 g++-6 python3-pip && \
+    apt-get autoremove -y
 
 CMD /var/faf-aio-replayserver/run.sh

Dockerfile

@@ -9,3 +9,4 @@ pytest-cov = "==2.5.1"
 pytest-timeout = "==1.3.1"
 pytest-asyncio = "==0.9.0"
 bugsnag = "==3.4.2"
+replay-parser = {git = "https://github.com/FAForever/faf-scfa-replay-parser.git", editable = true}

Pipfile

@@ -4,4 +4,4 @@ pyclean .
 rm -r tmp/*
 rm -r replays/*
 
-DATABASE_WRITE_WAIT_TIME=0.1 REPLAY_TIMEOUT=1 python3.6 -m pytest --cov=replay_server --cov-report=html -rxs `find ./tests/fixtures/ ./tests/server/ ./tests/conftest.py -iname "*.py"`
+DATABASE_WRITE_WAIT_TIME=0.1 REPLAY_TIMEOUT=1 python3.6 -m pytest --cov=replay_server  -rxs `find ./tests/fixtures/ ./tests/server/ ./tests/conftest.py -iname "*.py"`

Pipfile.lock

@@ -1,4 +1,4 @@
 #!/usr/bin/env bash
 
-docker build --rm=true --tag=faf-aio-replayserver .
+docker build --rm=true --tag=faforever/faf-aio-replayserver .
 echo "Docker container has been build 'faf-aio-replayserver'"

coverage.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 
 VERSION=`grep "LABEL version" Dockerfile | cut -d'"' -f2`
-IMAGE_VERSION="faf-aio-replayserver:$VERSION"
+IMAGE_VERSION="faforever/faf-aio-replayserver:$VERSION"
 
 docker stop faf-aio-replayserver
 docker rm faf-aio-replayserver

docker-build.sh

@@ -12,6 +12,6 @@ REPLAY_TIMEOUT=0 PYTHONPATH=$DIR python3.6 $DIR/replay_server/__main__.py &
 SERVER_PID=$!
 sleep 1
 
-LIVE_TEST=1 DATABASE_WRITE_WAIT_TIME=0.1 REPLAY_TIMEOUT=1 python3.6 -m pytest -rxs `find ./tests/conftest.py ./tests/fixtures/ ./tests/live_server/ -iname "*.py"`
+LIVE_TEST=1 DATABASE_WRITE_WAIT_TIME=0.1 REPLAY_TIMEOUT=1 python3.6 -m pytest --cov=replay_server -rxs `find ./tests/conftest.py ./tests/fixtures/ ./tests/live_server/ -iname "*.py"`
 
 kill $SERVER_PID

docker-run.sh

@@ -34,7 +34,7 @@ async def determine_type(self) -> Optional[int]:
         """
         Determines which action client is asking for.
         """
-        logger.debug("Determining action type")
+        logger.debug("<%s> Determining action type", self)
         try:
             action = await self.get_type()
             if action is None:
@@ -47,7 +47,7 @@ async def get_replay_name(self) -> Tuple[int, str]:
         """
         Parses request and returns uid & name
         """
-        logger.debug("Getting replay name")
+        logger.debug("<%s> Getting replay name", self)
         try:
             line = (await self.reader.readuntil(TERMINATOR))[:-1].decode()
             self.uid, self.game_name = line.split("/", 1)
@@ -62,6 +62,9 @@ async def get_replay_name(self) -> Tuple[int, str]:
             raise ConnectionError("Replay name: Unexpected data received")
 
     async def close(self):
-        logger.debug("Closing connection...")
+        logger.debug("<%s> Closing connection...", self)
         self.writer.close()
-        logger.debug("Connection closed")
+        logger.debug("<%s> Connection closed", self)
+
+    def __str__(self):
+        return str(id(self))

livetest.sh

@@ -13,7 +13,8 @@
 WAIT_STEP = 0.1  # in seconds, it might influence fluent streaming, default is 0.1
 # Wait timeout, till we will send live stream back
 REPLAY_TIMEOUT = int(os.environ.get("REPLAY_TIMEOUT", 60 * 5))
-READ_BUFFER_SIZE = int(os.environ.get("READ_BUFFER_SIZE", 1024))
+READ_BUFFER_SIZE = 65535 + 1 + 2  # 65535 max tick size + 1 for type + 2 for tick content size
+TICK_COUNT_TIMEOUT = 3000  # 5 minutes * 10 tick per sec
 WRITE_BUFFER_SIZE = int(os.environ.get("WRITE_BUFFER_SIZE", 1024))
 DATABASE_WRITE_WAIT_TIME = float(os.environ.get("DATABASE_WRITE_WAIT_TIME", 10))
 # base for uploading streams