Skip to content

Commit e9313b1

Browse files
committed
☑️ Remove ChangeSet#prepopulate! test
This test is fragile in that it does not account for the fact that we can specify a :prepopulate option for a property. When you specify the `:prepopulate` option (as in `Hyrax::Form::PcdmCollection`) and use this shared spec, then the now deleted spec fails with no recourse. Related to: - samvera/hyrax#6702 - samvera/hyrax#6703
1 parent 0007796 commit e9313b1

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

lib/valkyrie/specs/shared_specs/change_set.rb

-8
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@
4141
end
4242
end
4343

44-
describe "#prepopulate!" do
45-
it "doesn't make it look changed" do
46-
expect(change_set).not_to be_changed
47-
change_set.prepopulate!
48-
expect(change_set).not_to be_changed
49-
end
50-
end
51-
5244
describe "#required?" do
5345
it "returns a boolean" do
5446
expect(change_set.required?(change_set.fields.keys.first)).to be_in [true, false]

0 commit comments

Comments
 (0)