Skip to content

Filter Expressions not working #8

@wesley-mixtelematics

Description

@wesley-mixtelematics

Hi,
Thanks for an awesome bit of code.

I found an issue in the class public static QueryRequest CopyQueryRequest(this QueryRequest queryRequest) in DynamoDBUtil . The variables FilterExpression and ExpressionAttributeValues aren't copied across during the deep copy. I've updated my local copy to the following:

 var copiedRequest = new QueryRequest
            {
                AttributesToGet = queryRequest.AttributesToGet.ToList(), // deep copy
                ConsistentRead = queryRequest.ConsistentRead,
                ExclusiveStartKey = queryRequest.ExclusiveStartKey.ToDictionary(kvp => kvp.Key, kvp => kvp.Value), // deep copy
                IndexName = queryRequest.IndexName,
                KeyConditions = queryRequest.KeyConditions.ToDictionary(kvp => kvp.Key, kvp => kvp.Value),
                ReturnConsumedCapacity = queryRequest.ReturnConsumedCapacity,
                ScanIndexForward = queryRequest.ScanIndexForward,
                Select = queryRequest.Select,
                TableName = queryRequest.TableName,
                FilterExpression = queryRequest.FilterExpression, // <-- was missing
                ExpressionAttributeValues = queryRequest.ExpressionAttributeValues.ToDictionary(kvp => kvp.Key, kvp => kvp.Value) // <-- was missing
            };

and now the code works as expected when wanting to filter query results.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions