Skip to content

Commit f4bfc42

Browse files
committed
kconfig: nrf_cloud_pgps: Remove unsupported nRF Cloud config options
Signed-off-by: Gregers Gram Rygg <[email protected]>
1 parent 145b87e commit f4bfc42

File tree

3 files changed

+3
-29
lines changed

3 files changed

+3
-29
lines changed

doc/nrf/libraries/networking/nrf_cloud_pgps.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ Configure one of the following options to control the network transport for down
4949

5050
Configure these additional options to refine the behavior of P-GPS:
5151

52-
* :kconfig:option:`CONFIG_NRF_CLOUD_PGPS_PREDICTION_PERIOD`
5352
* :kconfig:option:`CONFIG_NRF_CLOUD_PGPS_NUM_PREDICTIONS`
5453
* :kconfig:option:`CONFIG_NRF_CLOUD_PGPS_REPLACEMENT_THRESHOLD`
5554
* :kconfig:option:`CONFIG_NRF_CLOUD_PGPS_DOWNLOAD_FRAGMENT_SIZE`

subsys/net/lib/nrf_cloud/Kconfig.nrf_cloud_pgps

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -25,32 +25,11 @@ config NRF_CLOUD_PGPS_REQUEST_UPON_INIT
2525
if only some of the predictions are in storage,
2626
or if the replacement threshold is reached.
2727

28-
choice NRF_CLOUD_PGPS_PREDICTION_PERIOD
29-
prompt "Desired time between predictions"
30-
default NRF_CLOUD_PGPS_PREDICTION_PERIOD_240_MIN
31-
help
32-
This value is used when requesting predicted GPS data from the
33-
cloud. More frequent predictions will result in more accurate
34-
ephemeris values for any given time, but will take more storage
35-
space in flash.
36-
37-
config NRF_CLOUD_PGPS_PREDICTION_PERIOD_120_MIN
38-
bool "120 min prediction period"
39-
help
40-
Each prediction is used to cover 120 minutes. May increase fix
41-
accuracy compared to 240 minute prediction period, but doubles
42-
the amount of data transferred and storage space needed in flash.
43-
44-
config NRF_CLOUD_PGPS_PREDICTION_PERIOD_240_MIN
45-
bool "240 min prediction period"
46-
help
47-
Each prediction is used to cover 240 minutes.
48-
4928
endchoice
5029

5130
config NRF_CLOUD_PGPS_NUM_PREDICTIONS
5231
int "Desired number of predictions"
53-
range 2 84
32+
range 2 42
5433
default 42
5534
help
5635
This value, together with the prediction period, determines the
@@ -60,7 +39,7 @@ config NRF_CLOUD_PGPS_NUM_PREDICTIONS
6039

6140
config NRF_CLOUD_PGPS_REPLACEMENT_THRESHOLD
6241
int "Number of predictions remaining before fetching more"
63-
range 0 82
42+
range 0 40
6443
default 0
6544
help
6645
When set to 0, no attempt will be made to update the prediction
@@ -175,7 +154,7 @@ config NRF_CLOUD_PGPS_PARTITION_SIZE
175154
hex "Size of flash partition for P-GPS data storage"
176155
default 0x15000
177156
help
178-
This must be at least 2048 bytes times NRF_COUND_PGPS_NUM_PREDICTIONS.
157+
This must be at least 2048 bytes times NRF_CLOUD_PGPS_NUM_PREDICTIONS.
179158

180159
config NRF_CLOUD_PGPS_PARTITION_ALIGN
181160
hex "Align P-GPS partition to flash block boundary"

subsys/net/lib/nrf_cloud/common/src/nrf_cloud_pgps.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,7 @@ LOG_MODULE_REGISTER(nrf_cloud_pgps, CONFIG_NRF_CLOUD_GPS_LOG_LEVEL);
3535
#define DOWNLOAD_PROTOCOL "https://"
3636
#define PGPS_DEBUG 0 /* set to 1 for extra logging */
3737

38-
#if defined(CONFIG_NRF_CLOUD_PGPS_PREDICTION_PERIOD_120_MIN)
39-
#define PREDICTION_PERIOD 120
40-
#else
4138
#define PREDICTION_PERIOD 240
42-
#endif
4339
#define REPLACEMENT_THRESHOLD CONFIG_NRF_CLOUD_PGPS_REPLACEMENT_THRESHOLD
4440
#define FRAGMENT_SIZE CONFIG_NRF_CLOUD_PGPS_DOWNLOAD_FRAGMENT_SIZE
4541
#define PREDICTION_MIDPOINT_SHIFT_SEC (120 * SEC_PER_MIN)

0 commit comments

Comments
 (0)