Process completed with exit code 1.

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details. MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided File:soc/nordic/common/soc_nrf_common.h Line:334

See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define GPIOTE_IRQ_HANDLER_CONNECT(node_id) \ - NRF_DT_IRQ_CONNECT( \ - node_id, \ - gpio_nrfx_gpiote_irq_handler, \ - &GPIOTE_NRFX_INST_BY_NODE(node_id) \ - ) - -#define GPIOTE_IRQ_DIRECT_DEFINE(node_id) \ - NRF_DT_IRQ_DIRECT_DEFINE( \ - node_id, \ - gpio_nrfx_gpiote_irq_handler, \ - &GPIOTE_NRFX_INST_BY_NODE(node_id) \ - ) +#define GPIOTE_IRQ_HANDLER_CONNECT(node_id) \ + NRF_DT_IRQ_CONNECT(node_id, gpio_nrfx_gpiote_irq_handler, \ + &GPIOTE_NRFX_INST_BY_NODE(node_id)) + +#define GPIOTE_IRQ_DIRECT_DEFINE(node_id) \ + NRF_DT_IRQ_DIRECT_DEFINE(node_id, gpio_nrfx_gpiote_irq_handler, \ + &GPIOTE_NRFX_INST_BY_NODE(node_id)) #ifdef CONFIG_GPIO_NRFX_INTERRUPT - DT_FOREACH_STATUS_OKAY(nordic_nrf_gpiote, GPIOTE_IRQ_DIRECT_DEFINE); +DT_FOREACH_STATUS_OKAY(nordic_nrf_gpiote, GPIOTE_IRQ_DIRECT_DEFINE); File:drivers/gpio/gpio_nrfx.c Line:613 You may want to run clang-format on this change: -#define I2C_NRFX_TWIM_DEVICE(inst) \ - NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ - NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ - BUILD_ASSERT(I2C_FREQUENCY(inst) != I2C_NRFX_TWIM_INVALID_FREQUENCY, \ - "Wrong I2C " #inst " frequency setting in dts"); \ - static struct i2c_nrfx_twim_data twim_##inst##_data; \ - static struct i2c_nrfx_twim_common_config twim_##inst##z_config; \ - NRF_DT_INST_IRQ_DIRECT_DEFINE( \ - inst, \ - nrfx_twim_irq_handler, \ - &_CONCAT_3(twim_, inst, _data.twim) \ - ) \ - static void pre_init##inst(void) \ - { \ - twim_##inst##z_config.twim = &twim_##inst##_data.twim; \ - twim_##inst##_data.twim.p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst); \ - NRF_DT_INST_IRQ_CONNECT( \ - inst, \ - nrfx_twim_irq_handler, \ - &_CONCAT_3(twim_, inst, _data.twim) \ - ) \ - } \ +#define I2C_NRFX_TWIM_DEVICE(inst) \ + NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ + NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ + BUILD_ASSERT(I2C_FREQUENCY(inst) != I2C_NRFX_TWIM_INVALID_FREQUENCY, \ + "Wrong I2C " #inst " frequency setting in dts"); \ + static struct i2c_nrfx_twim_data twim_##inst##_data; \ + static struct i2c_nrfx_twim_common_config twim_##inst##z_config; \ + NRF_DT_INST_IRQ_DIRECT_DEFINE(inst, nrfx_twim_irq_handler, \ + &_CONCAT_3(twim_, inst, _data.twim)) \ + static void pre_init##inst(void) \ + { \ + twim_##inst##z_config.twim = &twim_##inst##_data.twim; \ + twim_##inst##_data.twim.p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst); \ + NRF_DT_INST_IRQ_CONNECT(inst, nrfx_twim_irq_handler, \ + &_CONCAT_3(twim_, inst, _data.twim)) \ + } \ IF_ENABLED(USES_MSG_BUF(inst), \ (static uint8_t twim_##inst##_msg_buf[MSG_BUF_SIZE(inst)] \ - DMM_MEMORY_SECTION(DT_DRV_INST(inst));)) \ - PINCTRL_DT_INST_DEFINE(inst); \ - static struct i2c_nrfx_twim_common_c

soc/nordic/common/soc_nrf_common.h:334 Macros with flow control statements should be avoided

soc/nordic/common/soc_nrf_common.h:383 -#define NRF_DT_INST_IRQ_CONNECT(inst, handler, param) \ +#define NRF_DT_INST_IRQ_CONNECT(inst, handler, param) \

soc/nordic/common/soc_nrf_common.h:360 -#define NRF_DT_IRQ_CONNECT(node_id, handler, param) \ +#define NRF_DT_IRQ_CONNECT(node_id, handler, param) \

soc/nordic/common/soc_nrf_common.h:350 -#define NRF_DT_INST_IRQ_DIRECT_DEFINE(inst, handler, param) \ +#define NRF_DT_INST_IRQ_DIRECT_DEFINE(inst, handler, param) \

soc/nordic/common/soc_nrf_common.h:335 -#define NRF_DT_IRQ_DIRECT_DEFINE(node_id, handler, param) \ +#define NRF_DT_IRQ_DIRECT_DEFINE(node_id, handler, param) \

drivers/spi/spi_nrfx_spim.c:666 -#define SPI_NRFX_SPIM_DEFINE(inst) \ - NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ - NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ +#define SPI_NRFX_SPIM_DEFINE(inst) \ + NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ + NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ IF_ENABLED(SPI_BUFFER_IN_RAM, \ (static uint8_t spim_##inst##_tx_buffer \ [CONFIG_SPI_NRFX_RAM_BUFFER_SIZE] \ DMM_MEMORY_SECTION(DT_DRV_INST(inst)); \ static uint8_t spim_##inst##_rx_buffer \ [CONFIG_SPI_NRFX_RAM_BUFFER_SIZE] \ - DMM_MEMORY_SECTION(DT_DRV_INST(inst));)) \ - static struct spi_nrfx_data spi_##inst##_data = { \ - .spim = NRFX_SPIM_INSTANCE(DT_INST_REG_ADDR(inst)), \ + DMM_MEMORY_SECTION(DT_DRV_INST(inst));)) \ + static struct spi_nrfx_data spi_##inst##_data = { \ + .spim = NRFX_SPIM_INSTANCE(DT_INST_REG_ADDR(inst)), \ IF_ENABLED(CONFIG_MULTITHREADING, \ - (SPI_CONTEXT_INIT_LOCK(spi_##inst##_data, ctx),)) \ - IF_ENABLED(CONFIG_MULTITHREADING, \ - (SPI_CONTEXT_INIT_SYNC(spi_##inst##_data, ctx),)) \ - SPI_CONTEXT_CS_GPIOS_INITIALIZE(DT_DRV_INST(inst), ctx) \ - IF_ENABLED(SPI_BUFFER_IN_RAM, \ + (SPI_CONTEXT_INIT_LOCK(spi_##inst##_data, ctx),)) \ + IF_ENABLED(CONFIG_MULTITHREADING, \ + (SPI_CONTEXT_INIT_SYNC(spi_##inst##_data, ctx),)) SPI_CONTEXT_CS_GPIOS_INITIALIZE(DT_DRV_INST(inst), \ + ctx) \ + IF_ENABLED(SPI_BUFFER_IN_RAM, \ (.tx_buffer = spim_##inst##_tx_buffer, \ - .rx_buffer = spim_##inst##_rx_buffer,)) \ - .dev = DEVICE_DT_GET(DT_DRV_INST(inst)), \ - .busy = false, \ - }; \ - NRF_DT_INST_IRQ_DIRECT_DEFINE( \ - inst, \ - nrfx_spim_irq_handler, \ - &_CONCAT_3(spi_, inst, _data.spim) \ - ) \ - static void irq_connect##inst(void) \ - { \ - NRF_DT_INST_IRQ_CONNECT( \ - inst, \ - nrfx_spim_irq_handler, \ - &_CONCAT_3(spi_, inst, _data.spim) \ - ); \ - } \ - PINCTRL_DT_INST_DEFINE(inst); \ - static const struct spi_nrfx_config spi_##inst##z_config = { \ - .max_freq = DT_INST_PROP(inst, max_frequency), \ - .def_config = { \ - .skip_gpio_cfg = true, \ - .skip_psel_cfg = true, \ - .ss_pin = NRF_SPIM_PIN_NOT_CONNECTED, \ - .orc = DT_INST_PROP(inst, overrun_character), \ - SPI_NRFX_SPIM_EXTENDED_CONFIG(inst) \ - }, \ - .irq_connect = irq_connect##inst, \ - .max_chunk_len = BIT_MASK( \ - DT_INST_PROP(inst, easydma_maxcnt_bits)), \ - .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(inst), \ - .wake_gpiote = WAKE_GPIOTE_NODE(DT_DRV_INST(inst)), \ - .wake_pin = NRF_DT_GPIOS_TO_PSEL_OR(DT_DRV_INST(inst), \ - wake_gpios, \ - WAKE_PIN_NOT_USED), \ - .mem_reg = DMM_DEV_TO_REG(DT_DRV_INST(inst)), \ - }; \ - BUILD_ASSERT(!DT_INST_NODE_HAS_PROP(inst, wake_gpios) || \ - !(DT_GPIO_FLAGS(DT_DRV_INST(inst), wake_gpios) & \ - GPIO_ACTIVE_LOW), \ - "WAKE line must be configured as active high"); \ - PM_DEVICE_DT_INST_DEFINE(inst, spim_nrfx_pm_action); \ - SPI_DEVICE_DT_INST_DEINIT_DEFINE(inst, \ - spi_nrfx_init, \ - spi_nrfx_deinit, \ - PM_DEVICE_DT_INST_GET(inst), \ -

drivers/i2c/i2c_nrfx_twis.c:348 - PM_DEVICE_DT_INST_DEFINE(id, shim_nrf_twis_pm_action_cb,); \ + PM_DEVICE_DT_INST_DEFINE(id, shim_nrf_twis_pm_action_cb, ); \

drivers/i2c/i2c_nrfx_twis.c:328 - NRF_DT_INST_IRQ_DIRECT_DEFINE( \ - id, \ - nrfx_twis_irq_handler, \ - &SHIM_NRF_TWIS_NAME(id, data).twis \ - ) \ + NRF_DT_INST_IRQ_DIRECT_DEFINE(id, nrfx_twis_irq_handler, \ + &SHIM_NRF_TWIS_NAME(id, data).twis) \ \ static void SHIM_NRF_TWIS_NAME(id, pre_init)(void) \ { \ SHIM_NRF_TWIS_NAME(id, data).twis.p_reg = (NRF_TWIS_Type *)DT_INST_REG_ADDR(id); \ - NRF_DT_INST_IRQ_CONNECT( \ - id, \ - nrfx_twis_irq_handler, \ - &SHIM_NRF_TWIS_NAME(id, data).twis \ - ) \ + NRF_DT_INST_IRQ_CONNECT(id, nrfx_twis_irq_handler, \ + &SHIM_NRF_TWIS_NAME(id, data).twis) \

drivers/i2c/i2c_nrfx_twim_rtio.c:298 -#define I2C_NRFX_TWIM_RTIO_DEVICE(inst) \ - NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ - NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ - BUILD_ASSERT(I2C_FREQUENCY(inst) != I2C_NRFX_TWIM_INVALID_FREQUENCY, \ - "Wrong I2C " #inst " frequency setting in dts"); \ - static struct i2c_nrfx_twim_rtio_data twim_##inst##z_data = { \ - .twim = \ - { \ - .p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst), \ - }, \ - }; \ - NRF_DT_INST_IRQ_DIRECT_DEFINE( \ - inst, \ - nrfx_twim_irq_handler, \ - &_CONCAT_3(twim_, inst, z_data.twim) \ - ) \ - static void pre_init##inst(void) \ - { \ - twim_##inst##z_data.twim.p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst); \ - NRF_DT_INST_IRQ_CONNECT( \ - inst, \ - nrfx_twim_irq_handler, \ - &_CONCAT_3(twim_, inst, z_data.twim) \ - ) \ - } \ - IF_ENABLED(USES_MSG_BUF(inst), (MSG_BUF_DEFINE(inst);)) \ - I2C_RTIO_DEFINE(_i2c##inst##_twim_rtio, \ - DT_INST_PROP_OR(n, sq_size, CONFIG_I2C_RTIO_SQ_SIZE), \ - DT_INST_PROP_OR(n, cq_size, CONFIG_I2C_RTIO_CQ_SIZE)); \ - PINCTRL_DT_INST_DEFINE(inst); \ - static const struct i2c_nrfx_twim_rtio_config twim_##inst##z_config = { \ - .common = \ - { \ - .twim_config = \ - { \ - .skip_gpio_cfg = true, \ - .skip_psel_cfg = true, \ - .frequency = I2C_FREQUENCY(inst), \ - }, \ - .event_handler = event_handler, \ - .msg_buf_size = MSG_BUF_SIZE(inst), \ - .pre_init = pre_init##inst, \ - .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(inst), \ - IF_ENABLED(USES_MSG_BUF(inst), (.msg_buf = MSG_BUF_SYM(inst),)) \ - .max_transfer_size = MAX_TRANSFER_SIZE(inst), \ - .twim = &twim_##inst##z_data.twim, \ - }, \ - .ctx = &_i2c##inst##_twim_rtio, \ - }; \ - PM_DEVICE_DT_INST_DEFINE(inst, twim_nrfx_pm_action, I2C_PM_ISR_SAFE(inst)); \ - I2C_DEVICE_DT_INST_DEINIT_DEFINE(inst, i2c_nrfx_twim_rtio_init, \ - i2c_nrfx_twim_rtio_deinit, \ - PM_DEVICE_DT_INST_GET(inst), &twim_##inst##z_data, \ - &twim_##inst##z_config, POST_KERNEL, \ - CONFIG_I2C_INIT_PRIORITY, &i2c_nrfx_twim_driver_api); \ +#define I2C_NRFX_TWIM_RTIO_DEVICE(inst) \ + NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ + NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ + BUILD_ASSERT(I2C_FREQUENCY(inst) != I2C_NRFX_TWIM_INVALID_FREQUENCY, \ + "Wrong I2C " #inst " frequency setting in dts"); \ + static struct i2c_nrfx_twim_rtio_data twim_##inst##z_data = { \ + .twim = \ + { \ + .p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst), \ + }, \ + }; \ + NRF_DT_INST_IRQ_DIRECT_DEFINE(inst, nrfx_twim_irq_handler, \ + &_CONCAT_3(twim_, inst, z_data.twim)) \ + static void pre_init##inst(void) \ + { \ + twim_##inst##z_data.twim.p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst); \ + NRF_DT_INST_IRQ_CONNECT(inst, nrfx_twim_irq_handler, \ + &_CONCAT_3(twim_, inst, z_data.twim)) \ + } \ + IF_ENABLED(U

drivers/i2c/i2c_nrfx_twim.c:322 -#define I2C_NRFX_TWIM_DEVICE(inst) \ - NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ - NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ - BUILD_ASSERT(I2C_FREQUENCY(inst) != I2C_NRFX_TWIM_INVALID_FREQUENCY, \ - "Wrong I2C " #inst " frequency setting in dts"); \ - static struct i2c_nrfx_twim_data twim_##inst##_data; \ - static struct i2c_nrfx_twim_common_config twim_##inst##z_config; \ - NRF_DT_INST_IRQ_DIRECT_DEFINE( \ - inst, \ - nrfx_twim_irq_handler, \ - &_CONCAT_3(twim_, inst, _data.twim) \ - ) \ - static void pre_init##inst(void) \ - { \ - twim_##inst##z_config.twim = &twim_##inst##_data.twim; \ - twim_##inst##_data.twim.p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst); \ - NRF_DT_INST_IRQ_CONNECT( \ - inst, \ - nrfx_twim_irq_handler, \ - &_CONCAT_3(twim_, inst, _data.twim) \ - ) \ - } \ +#define I2C_NRFX_TWIM_DEVICE(inst) \ + NRF_DT_CHECK_NODE_HAS_PINCTRL_SLEEP(DT_DRV_INST(inst)); \ + NRF_DT_CHECK_NODE_HAS_REQUIRED_MEMORY_REGIONS(DT_DRV_INST(inst)); \ + BUILD_ASSERT(I2C_FREQUENCY(inst) != I2C_NRFX_TWIM_INVALID_FREQUENCY, \ + "Wrong I2C " #inst " frequency setting in dts"); \ + static struct i2c_nrfx_twim_data twim_##inst##_data; \ + static struct i2c_nrfx_twim_common_config twim_##inst##z_config; \ + NRF_DT_INST_IRQ_DIRECT_DEFINE(inst, nrfx_twim_irq_handler, \ + &_CONCAT_3(twim_, inst, _data.twim)) \ + static void pre_init##inst(void) \ + { \ + twim_##inst##z_config.twim = &twim_##inst##_data.twim; \ + twim_##inst##_data.twim.p_twim = (NRF_TWIM_Type *)DT_INST_REG_ADDR(inst); \ + NRF_DT_INST_IRQ_CONNECT(inst, nrfx_twim_irq_handler, \ + &_CONCAT_3(twim_, inst, _data.twim)) \ + } \ IF_ENABLED(USES_MSG_BUF(inst), \ (static uint8_t twim_##inst##_msg_buf[MSG_BUF_SIZE(inst)] \ - DMM_MEMORY_SECTION(DT_DRV_INST(inst));)) \ - PINCTRL_DT_INST_DEFINE(inst); \ - static struct i2c_nrfx_twim_common_config twim_##inst##z_config = { \ - .twim_config = \ - { \ - .skip_gpio_cfg = true, \ - .skip_psel_cfg = true, \ - .frequency = I2C_FREQUENCY(inst), \ - }, \ - .event_handler = event_handler, \ - .msg_buf_size = MSG_BUF_SIZE(inst), \ - .pre_init = pre_init##inst, \ - .pcfg = PINCTRL_DT_INST_DEV_CONFIG_GET(inst), \ + DMM_MEMORY_SECTION(DT_DRV_INST(inst));)) \ + PINCTRL_DT_INST_DEFINE(inst); \ + static struct i2c_nrfx_twim_common_config twim_##inst##z_config = { \ + .twim_config = \ + { \ + .skip_gpio_cfg = true, \ + .skip_psel_cfg = true, \ + .frequency = I2C_FREQUENCY(inst), \ + }, \ + .event_handler = event_handler,