Skip to content

Don't reconnect to all connections every time the lookupd job is run #4

@werkshy

Description

@werkshy
Contributor

It looks like we call reader.connectToNsqd() for every producer on every poll of lookupd, and we never disconnect from producers that lookupd doesn't respond to.

It seems like we should compare the list that lookupd returns to the list we have open, and open/close connections until we are reconciled.

Activity

danielhfrank

danielhfrank commented on Apr 15, 2013

@danielhfrank
Contributor

Yeah, that's correct. Clearly I wrote that only thinking about the initial connection. Will fix once I bring your pull req in

danielhfrank

danielhfrank commented on Apr 15, 2013

@danielhfrank
Contributor

Err, I see you may have actually done some work on this one already. We'll get to it next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @werkshy@danielhfrank

        Issue actions

          Don't reconnect to all connections every time the lookupd job is run · Issue #4 · nsqio/nsq-java