Skip to content

makes page limit env var #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

makes page limit env var #3533

merged 1 commit into from
Jun 2, 2025

Conversation

nickzelei
Copy link
Member

No description provided.

@nickzelei nickzelei requested a review from alishakawaguchi June 2, 2025 23:26
@nickzelei nickzelei added the Improvement Created by Linear-GitHub Sync label Jun 2, 2025
@vercel Vercel
Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Jun 2, 2025 11:26pm

@codecov Codecov
Copy link

codecov bot commented Jun 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.04%. Comparing base (0b70525) to head (3db18cb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
worker/internal/cmds/worker/serve/serve.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3533      +/-   ##
==========================================
- Coverage   24.05%   24.04%   -0.01%     
==========================================
  Files         421      421              
  Lines       56446    56449       +3     
==========================================
- Hits        13576    13573       -3     
- Misses      41687    41692       +5     
- Partials     1183     1184       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickzelei nickzelei merged commit f1704d4 into main Jun 2, 2025
13 of 16 checks passed
@nickzelei nickzelei deleted the nick/updates-to-make-env branch June 2, 2025 23:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2025

Benchstat Geomean Results

-9.20% sec/op, -0.01% B/op, 0.00% allocs/op

Benchstat results 
                                                                 │ main-benchmark.txt │        branch-benchmark.txt         │
                                                                 │       sec/op       │    sec/op     vs base               │
CleanPostgresType-4                                                      42.66n ±  9%   41.47n ±  7%        ~ (p=0.082 n=6)
CleanMysqlType-4                                                         53.94n ±  0%   52.10n ±  4%   -3.41% (p=0.037 n=6)
Runner_Single-4                                                          7.701µ ±  3%   7.300µ ±  2%   -5.21% (p=0.002 n=6)
GenerateBool-4                                                           11.54n ±  1%   11.20n ±  5%        ~ (p=0.058 n=6)
GenerateBusinessName-4                                                   304.1n ±  9%   266.6n ±  9%  -12.32% (p=0.004 n=6)
GenerateCardNumber-4                                                     28.96n ±  6%   28.09n ±  1%   -3.00% (p=0.002 n=6)
GenerateCategorical-4                                                    93.68n ±  1%   90.70n ±  2%   -3.18% (p=0.002 n=6)
GenerateCity-4                                                           173.3n ±  2%   168.7n ±  1%   -2.68% (p=0.002 n=6)
GenerateCountry-4                                                        95.17n ±  2%   91.69n ±  3%   -3.67% (p=0.002 n=6)
GenerateEmail-4                                                         1308.5n ±  2%   643.7n ±  2%  -50.81% (p=0.002 n=6)
GenerateFirstName-4                                                      203.3n ±  0%   196.7n ±  1%   -3.27% (p=0.002 n=6)
GenerateFloat64-4                                                        26.39n ±  1%   25.94n ±  1%   -1.72% (p=0.002 n=6)
GenerateFullAddress-4                                                    1.411µ ±  0%   1.373µ ±  2%   -2.66% (p=0.002 n=6)
GenerateFullName-4                                                       1.204µ ±  2%   1.163µ ±  2%   -3.41% (p=0.002 n=6)
GenerateGender-4                                                         36.69n ±  0%   35.88n ±  2%   -2.19% (p=0.002 n=6)
GenerateInt64-4                                                          27.02n ±  0%   26.21n ±  1%   -2.98% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                                               51.15n ±  0%   49.99n ±  1%   -2.27% (p=0.002 n=6)
GenerateInternationalPhoneNumber-4                                       174.2n ±  0%   166.5n ±  1%   -4.39% (p=0.002 n=6)
GenerateIpAddress-4                                                      560.0n ±  2%   492.7n ±  2%  -12.03% (p=0.002 n=6)
GenerateLastName-4                                                       189.2n ±  1%   184.3n ±  0%   -2.56% (p=0.002 n=6)
GenerateRandomString-4                                                   264.9n ± 24%   258.8n ±  2%   -2.30% (p=0.002 n=6)
GenerateSHA256Hash-4                                                    1003.5n ±  1%   411.1n ±  2%  -59.04% (p=0.002 n=6)
GenerateSSN-4                                                            265.8n ±  3%   259.8n ±  1%   -2.28% (p=0.002 n=6)
GenerateState-4                                                          94.77n ±  2%   92.39n ±  1%   -2.51% (p=0.002 n=6)
GenerateStreetAddress-4                                                  207.5n ±  1%   199.1n ±  2%   -4.05% (p=0.002 n=6)
GenerateStringPhoneNumber-4                                              171.1n ±  0%   154.2n ±  2%   -9.85% (p=0.002 n=6)
GenerateUnixTimestamp-4                                                  77.04n ±  1%   73.38n ±  2%   -4.75% (p=0.002 n=6)
GenerateUsername-4                                                       346.1n ±  2%   339.0n ±  2%   -2.05% (p=0.002 n=6)
GenerateUTCTimestamp-4                                                  105.80n ±  1%   94.58n ±  1%  -10.60% (p=0.002 n=6)
GenerateUUID-4                                                           732.1n ±  1%   185.6n ±  3%  -74.65% (p=0.002 n=6)
GenerateZipcode-4                                                        93.42n ±  1%   90.90n ±  2%   -2.69% (p=0.002 n=6)
TransformCharacterScramble-4                                             159.9n ±  3%   156.5n ±  2%   -2.10% (p=0.002 n=6)
TransformE164PhoneNumber-4                                               171.6n ±  0%   164.7n ±  2%   -4.05% (p=0.002 n=6)
TransformEmail-4                                                         1.774µ ±  1%   1.056µ ±  1%  -40.48% (p=0.002 n=6)
TransformFirstName-4                                                     233.9n ±  1%   229.0n ±  2%   -2.14% (p=0.002 n=6)
TransformFloat64-4                                                      101.25n ±  1%   99.09n ±  2%   -2.13% (p=0.002 n=6)
TransformFullName-4                                                      1.236µ ±  2%   1.181µ ±  2%   -4.45% (p=0.002 n=6)
TransformInt64-4                                                         31.92n ±  2%   31.10n ±  4%   -2.54% (p=0.039 n=6)
TransformInt64PhoneNumber-4                                              57.88n ±  3%   57.05n ±  1%   -1.43% (p=0.002 n=6)
TransformLastName-4                                                      194.8n ±  1%   188.0n ±  1%   -3.49% (p=0.002 n=6)
TransformString-4                                                        291.5n ±  1%   286.6n ±  1%   -1.68% (p=0.004 n=6)
TransformStringPhoneNumber-4                                             198.8n ±  1%   182.2n ±  1%   -8.35% (p=0.002 n=6)
TransformUuid-4                                                          32.34n ±  0%   31.86n ±  1%   -1.50% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4                82.86n ±  0%   80.52n ±  1%   -2.82% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4             259.2n ±  3%   250.9n ±  4%   -3.20% (p=0.041 n=6)
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4            1.882µ ±  0%   1.819µ ±  2%   -3.32% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4              199.7n ±  0%   193.8n ±  3%   -2.95% (p=0.009 n=6)
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                 3.736n ±  2%   3.607n ±  1%   -3.45% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                   14.95µ ±  0%   14.61µ ±  3%   -2.26% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4            14.95µ ±  2%   16.33µ ± 10%        ~ (p=0.065 n=6)
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4         26.66µ ±  1%   28.52µ ±  2%   +6.99% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4              26.59µ ±  1%   28.46µ ±  1%   +7.02% (p=0.002 n=6)
geomean                                                                  240.5n         218.4n         -9.20%

                                                                 │ main-benchmark.txt │         branch-benchmark.txt         │
                                                                 │        B/op        │     B/op      vs base                │
CleanPostgresType-4                                                      0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
CleanMysqlType-4                                                         0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                                                        2.290Ki ± 1%     2.282Ki ± 2%       ~ (p=0.394 n=6)
GenerateBool-4                                                           0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                                                   304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                                                     8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                                                    64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                                                           160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                                                        24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                                                          385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                                                      208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                                                        8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                                                    512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                                                       418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                                                         16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                                                          7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                                               8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4                                       40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                                                      31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                                                       176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                                                   72.00 ± 0%       72.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                                                     288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                                                            46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                                                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                                                  240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                                              40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                                                  8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                                                       205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                                                   24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                                                           80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                                                        24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4                                             40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                                               40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                                                         489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                                                     224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                                                       88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                                                      418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                                                         8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                                              8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                                                      176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                                                        88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4                                             56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                                                          16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4                6.000 ± 0%       6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4             61.00 ± 0%       61.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4            582.0 ± 0%       582.0 ± 0%       ~ (p=1.000 n=6)
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4              64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                 0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                 34.43Ki ± 0%     34.42Ki ± 0%       ~ (p=0.699 n=6)
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4          34.44Ki ± 0%     34.44Ki ± 0%       ~ (p=0.667 n=6)
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4       64.00Ki ± 0%     64.00Ki ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4            64.00Ki ± 0%     64.00Ki ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                                             ²                 -0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                                                 │ main-benchmark.txt │        branch-benchmark.txt         │
                                                                 │     allocs/op      │  allocs/op   vs base                │
CleanPostgresType-4                                                     0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
CleanMysqlType-4                                                        0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                                                         24.00 ±  0%     24.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                                                          0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                                                  2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                                                    1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                                                   2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                                                          2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                                                       2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                                                         8.000 ±  0%     8.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                                                       1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                                                   10.00 ±  0%     10.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                                                      6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                                                        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                                                         0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                                              1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4                                      3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                                                      2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                                                  2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                                                    7.000 ±  0%     7.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                                                           3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateState-4                                                         2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                                                 2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                                             3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                                                 1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                                                      6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                                                  1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                                                          3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                                                       2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4                                            3.000 ± 33%     3.000 ± 33%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                                              3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                                                        14.00 ±  0%     14.00 ±  0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                                                    3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                                                      3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                                                     6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                                                        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                                             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformString-4                                                       3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4                                            4.000 ±  0%     4.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                                                         1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4               1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4            1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4           1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                  1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4           1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
geomean                                                                             ²                +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@BrewTestBot BrewTestBot mentioned this pull request Jun 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alishakawaguchi alishakawaguchi alishakawaguchi approved these changes

Assignees
No one assigned
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickzelei @alishakawaguchi