Cleanup some instances of project.json from the repo (dotnet#12484)

* Replace ScriptGenerator project.json with csproj

* Update project.json occurrences in docs
Fix few typos.

* Remove project.json comments

Author: am11

Documentation/building/windows-test-instructions.md

@@ -98,12 +98,12 @@ Note:
 
 1. You can disable building of a test per architecture or configuration by using DisableProjectBuild tag in the project. for example:
 
-  ``<PropertyGroup>``
+  ```xml
+  <PropertyGroup>
+    <DisableProjectBuild Condition=" '$(Platform)' == 'arm64' ">true</DisableProjectBuild>
+  </PropertyGroup>
+  ```
 
-     ``<DisableProjectBuild Condition=" '$(Platform)' == 'arm64' ">true</DisableProjectBuild>``
+2. To add Nuget/MyGet references use this (project file)[https://github.com/dotnet/coreclr/blob/master/tests/src/Common/test_dependencies/test_dependencies.csproj].
 
-  ``</PropertyGroup>``
-
-2. To Add Nuget\MyGet Refernces use this (project.json)[https://github.com/dotnet/coreclr/blob/master/tests/src/Common/test_dependencies/project.json]
-
-3. To Build against the mscorlib facade add  ``<ReferenceLocalMscorlib>true</ReferenceLocalMscorlib>`` to your project
+3. To build against the mscorlib facade add `<ReferenceLocalMscorlib>true</ReferenceLocalMscorlib>` to your project.

README.md

@@ -90,7 +90,7 @@ you use `dotnet.exe` for this).
 
 These extra pieces are not defined here, however you don't need to build them in order to use the CoreCLR 
 Nuget package you create here.   There are already versions of the CoreFX packages published on 
-https://www.nuget.org/ so you can have your test application's project.json specify the CoreCLR you 
+https://www.nuget.org/ so you can have your test application's project file specify the CoreCLR you 
 built and it will naturally pull anything else it needs from the official location https://www.nuget.org/ to 
 make a complete application.  More on this in the [Using Your Build](Documentation/workflow/UsingYourBuild.md) page.
 

tests/debugger_tests/ScriptGenerator/ScriptGenerator.csproj

@@ -0,0 +1,15 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>netcoreapp2.0</TargetFramework>
+    <AssemblyName>ScriptGenerator</AssemblyName>
+    <PackageId>ScriptGenerator</PackageId>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="xunit.core" Version="2.3.0-beta3-build3705" />
+    <PackageReference Include="System.Runtime.Loader" Version="4.3.0" />
+  </ItemGroup>
+
+</Project>

tests/debugger_tests/ScriptGenerator/project.json

@@ -39,7 +39,7 @@ def get_buildos():
         return 'OSX' if sysname.lower() == 'Darwin'.lower() else sysname
 
 def get_optdata_version(tool):
-    """Returns the version string specified in project.json for the given tool."""
+    """Returns the version string specified in project file for the given tool."""
     element_name = {
         'IBC': 'IbcDataPackageVersion',
         'PGO': 'PgoDataPackageVersion',

tests/scripts/optdata/bootstrap.py

@@ -28,10 +28,6 @@
   <ItemGroup>
     <Compile Include="CoreFX_15913.cs" />
   </ItemGroup>
-  <!--  <PropertyGroup>
-    <ProjectJson>$(JitPackagesConfigFileDirectory)threading+thread\project.json</ProjectJson>
-    <ProjectLockJson>$(JitPackagesConfigFileDirectory)threading+thread\project.lock.json</ProjectLockJson>
-  </PropertyGroup>-->
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
   <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' "></PropertyGroup>
 </Project>

tests/scripts/project.json

@@ -28,10 +28,6 @@
   <ItemGroup>
     <Compile Include="GitHub_11508.cs" />
   </ItemGroup>
-  <!--  <PropertyGroup>
-    <ProjectJson>$(JitPackagesConfigFileDirectory)threading+thread\project.json</ProjectJson>
-    <ProjectLockJson>$(JitPackagesConfigFileDirectory)threading+thread\project.lock.json</ProjectLockJson>
-  </PropertyGroup>-->
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
   <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' "></PropertyGroup>
 </Project>

tests/src/JIT/Regression/JitBlue/CoreFX_15913/CoreFX_15913.csproj

@@ -28,10 +28,6 @@
   <ItemGroup>
     <Compile Include="GitHub_11574.cs" />
   </ItemGroup>
-  <!--  <PropertyGroup>
-    <ProjectJson>$(JitPackagesConfigFileDirectory)threading+thread\project.json</ProjectJson>
-    <ProjectLockJson>$(JitPackagesConfigFileDirectory)threading+thread\project.lock.json</ProjectLockJson>
-  </PropertyGroup>-->
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
   <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' "></PropertyGroup>
 </Project>

tests/src/JIT/Regression/JitBlue/GitHub_11508/GitHub_11508.csproj

@@ -28,10 +28,6 @@
   <ItemGroup>
     <Compile Include="AbsGeneric.cs" />
   </ItemGroup>
-  <!--  <PropertyGroup>
-    <ProjectJson>$(JitPackagesConfigFileDirectory)threading+thread\project.json</ProjectJson>
-    <ProjectLockJson>$(JitPackagesConfigFileDirectory)threading+thread\project.lock.json</ProjectLockJson>
-  </PropertyGroup>-->
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
   <PropertyGroup Condition=" '$(MsBuildProjectDirOverride)' != '' "></PropertyGroup>
 </Project>