virtual subscriblines and safe exit code checks

Author: Mpdreamz

global.json

@@ -3,6 +3,6 @@
     "version": "2.0.3"
   },
   "versions": {
-    "proc": "v0.1.3"
+    "proc": "v0.1.4"
   }
 }

src/Proc/ObservableProcess.cs

@@ -122,13 +122,13 @@ public IDisposable Subscribe(IObserver<LineOut> observer)
 			return new CompositeDisposable(newlines, connected);
 		}
 
-		public IDisposable SubscribeLines(Action<LineOut> onNext, Action<Exception> onError, Action onCompleted) =>
+		public virtual IDisposable SubscribeLines(Action<LineOut> onNext, Action<Exception> onError, Action onCompleted) =>
 			this.Subscribe(Observer.Create(onNext, onError, onCompleted));
 
-		public IDisposable SubscribeLines(Action<LineOut> onNext, Action<Exception> onError) =>
+		public virtual IDisposable SubscribeLines(Action<LineOut> onNext, Action<Exception> onError) =>
 			this.Subscribe(Observer.Create(onNext, onError, delegate { }));
 
-		public IDisposable SubscribeLines(Action<LineOut> onNext) =>
+		public virtual IDisposable SubscribeLines(Action<LineOut> onNext) =>
 			this.Subscribe(Observer.Create(onNext, delegate { }, delegate { }));
 
 		private void OnNextConsoleOut(CharactersOut c, IObserver<CharactersOut> observer)

src/Proc/ObservableProcessBase.cs

@@ -101,6 +101,8 @@ protected void OnExit(IObserver<TConsoleOut> observer)
 			{
 				exitCode = this.Process.ExitCode;
 			}
+			//ExitCode and HasExited are all trigger happy. We are aware the process may or may not have an exit code.
+			catch (InvalidOperationException) { }
 			finally
 			{
 				ExitStop(observer, exitCode);
@@ -249,10 +251,7 @@ private void Stop(int? exitCode = null, IObserver<TConsoleOut> observer = null)
 				//Access denied usually means the program is already terminating.
 				catch (Win32Exception) { }
 				//This usually indiciates the process is already terminated
-				catch (InvalidOperationException)
-				{
-				}
-
+				catch (InvalidOperationException) { }
 				try
 				{
 					this.Process?.Dispose();