formatting and minor fixes

Author: yashssh

ffi/newpassmanagers.cpp

@@ -315,7 +315,7 @@ API_EXPORT(void)
 LLVMPY_SetTimePassesNPM(LLVMTimePassesHandlerRef TimePasses,
                         LLVMPassInstrumentationCallbacksRef PIC) {
     TimePassesHandler *TP = llvm::unwrap(TimePasses);
-    TP->print();
+    TimePassesIsEnabled = true;
     TP->registerCallbacks(*llvm::unwrap(PIC));
 }
 
@@ -329,6 +329,7 @@ LLVMPY_ReportAndResetTimingsNPM(LLVMTimePassesHandlerRef TimePasses,
     TP->print();
     os.flush();
     *outmsg = LLVMPY_CreateString(os.str().c_str());
+    TimePassesIsEnabled = false;
 }
 
 API_EXPORT(LLVMPassBuilderRef)

llvmlite/binding/newpassmanagers.py

@@ -247,13 +247,8 @@ def getFunctionPassManager(self):
                 self, self._pto.speed_level, self._pto.size_level)
         )
 
-    def set_time_passes(self, enable):
-        """Enable or disable the pass timers.
-        Parameters
-        ----------
-        enable : bool
-            Set to True to enable the pass timers.
-            Set to False to disable the pass timers.
+    def set_time_passes(self):
+        """Enable the pass timers.
         """
         ffi.lib.LLVMPY_SetTimePassesNPM(self._time_passes, self._pic)
 

llvmlite/tests/test_binding.py

@@ -3071,11 +3071,10 @@ def test_time_passes(self):
         def run_with_timing(speed_level):
             mod = self.module()
             pb = self.pb(speed_level=speed_level, size_level=0)
-            pb.set_time_passes(True)
+            pb.set_time_passes()
             mpm = pb.getModulePassManager()
             mpm.run(mod, pb)
             report = pb.report_and_reset_timings()
-            pb.set_time_passes(False)
             pb.close()
             return report
 
@@ -3087,6 +3086,15 @@ def run_with_timing(speed_level):
         self.assertEqual(report_O3.count("Pass execution timing report"), 1)
         self.assertEqual(report_O0.count("Pass execution timing report"), 1)
 
+    def test_empty_report(self):
+        mod = self.module()
+        pb = self.pb()
+        mpm = pb.getModulePassManager()
+        mpm.run(mod, pb)
+        report = pb.report_and_reset_timings()
+        pb.close()
+        self.assertFalse(report)
+
 
 class TestNewModulePassManager(BaseTest, NewPassManagerMixin):
     def pm(self):