Create version.json files on both backend and frontend on push #524
+63
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morendil
force-pushed
the
generate-version
branch
from
06137c6
to
2e5bf12
Compare
Morendil
force-pushed
the
generate-version
branch
4 times, most recently
from
ed9b51b
to
369bff9
Compare
This supplements the release process. We inject Github metadata into two version.json files; the 'version' value will depend on the type of event, for release tag events it should be the same as the release tag (i.e. the app version). This should make version information available to the /config endpoint on any push, and the frontend should display the backend version. (For extra safety we will also want to get the frontend version and display that, but this commit only supplies the barest necessities.)
Morendil
force-pushed
the
generate-version
branch
7 times, most recently
from
f94b192
to
796586d
Compare
We add the machinery to get version information and display it discreetly.
Morendil
force-pushed
the
generate-version
branch
from
796586d
to
3e77c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Display version information in the app's footer to help acceptance testing and debugging.
Fixes #510
Proposal
This supplements the release process. We inject Github metadata into two version.json files; the 'version' value will be filled with
github.ref_name, which will depend on the type of event, for release tag events it should be the same as the release tag (i.e. the app version). This should make version information available to the /config endpoint on any push, and the frontend should display the backend version.Relevant documentation: Accessing contextual information about workflow runs