Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create version.json files on both backend and frontend on push #524

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Morendil
Copy link
Contributor

Purpose

Display version information in the app's footer to help acceptance testing and debugging.

Fixes #510

Proposal

This supplements the release process. We inject Github metadata into two version.json files; the 'version' value will be filled with github.ref_name, which will depend on the type of event, for release tag events it should be the same as the release tag (i.e. the app version). This should make version information available to the /config endpoint on any push, and the frontend should display the backend version.

Relevant documentation: Accessing contextual information about workflow runs

@Morendil Morendil marked this pull request as draft November 15, 2024 14:08
@Morendil Morendil force-pushed the generate-version branch 13 times, most recently from 9655190 to 46e2f22 Compare November 18, 2024 10:08
@Morendil Morendil marked this pull request as ready for review November 18, 2024 16:13
@Morendil Morendil force-pushed the generate-version branch 10 times, most recently from ac34b6c to b5ba458 Compare November 19, 2024 14:58
@Morendil Morendil enabled auto-merge (rebase) November 19, 2024 17:18
This supplements the release process. We inject Github metadata into two
version.json files; the 'version' value will depend on the type of event,
for release tag events it should be the same as the release tag (i.e. the
app version). This should make version information available to the /config
endpoint on any push, and the frontend should display the backend version.
(For extra safety we will also want to get the frontend version and display
that, but this commit only supplies the barest necessities.)
We add the machinery to get version information and display it discreetly.
@Morendil Morendil merged commit 43c18cb into main Nov 19, 2024
20 checks passed
@Morendil Morendil deleted the generate-version branch November 19, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix version display
2 participants