Nushell / VSCode IDE Integration LSP Bughunt & Features

[fdncred]

This is a list to document bugs found in the LSP or IDE functionality from nushell. Also to list existing functionality and missing features we want to add.

Bugs?

Inlays

• No inlays in env.nu (let-env's are not variables and therefore do not have inlays. i mistakenly thought they should)
• No inlays in (Darren's) config.nu (it's a bit flaky. Sometimes works. Sometimes doesn't work. Doesn't work at all for let-env config =)
• Inlays are using shape? instead of type (they're capitalized). Fixed in make inlays show type instead of shape nushell#8801

Hover

• No hovers in (Darren's) config.nu (caused complex by big script?)
• Too many hover messages (Go to a script that is working, hover by moving mouse horizontally along and watch the debug. there are lots of messages with the same info. could be just duplicate logging without uniq names, or could be some type of bug where we're calling nushell too many times. could be what throttling is about? 💡 maybe store current cursor position and not update if it's in a certain range. very minute changes in cursor position currently run the nushell code again.) Marked as done because we have to pass the cursor position
• Hover over command with a sub-command, the command has a popup, the sub-command says "string" in the popup. Would be nice to treat this as one command.
• Hover over the custom command name in the declaration of the def should show the help text
• Hover improve built-ins Improve hovers, including for custom commands nushell#8881
• Hover scrollbar sometimes is at the bottom instead of top
• Hover messes up tables like in the ansi command
• Hover doesn't work at end of file Limit buffer calculation to buffer size not text size #99

Goto Definition

• Goto Definition goes to the start of the block versus the start of the custom command

Completions

• Fix variable completions when inside of a block that introduces a new variable

Errors & Warnings

• Shows only 1 error squiggly. Fixed by Refactor to support multiple parse errors nushell#8765.
• Better operator mismatch errors. improve operation mismatch errors nushell#8800
• Fix bundling update files to model after jakt #101
• errors when creating scripts from vscode (Request textDocument/completion failed.)

Validation / Check

• Throttle the validation (show the nu language server output and start typing in a script. Do we need to reparse the entire script on every character? (Look at jakt's throttle again) add a throttle timeout so that we don't update to frequently #106

Configuration

• Respect Max Number of Problems i.e. number of red squiggly lines limit the amount of errors returned by ide-check #98 limit the ide-check error amount nushell#8875
• Ensure Show Inferred Types checkbox is respected respect the setting to enable or disable hints/inlays #97
• Optimal setting for Max Nushell Invocation Time
• Grab Nushell Executable Path from extension launch since it looks for it
• Not sure if anything needs to be done with Trace: Server

Potential Features to Add

• Refactor... - Ability to click refactor over a var or def and do the normal vcode search & replace
• Find All References
• Multi file IDE support Adds multi-file support to IDE support nushell#8857
• Semantic highlighting https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide

Existing Functionality

• Goto Definition
• Hover over variables and get type
• Hover over custom command and show help popup
• Hover over built-in command and show help popup
• Show errors with a red squiggly line
• Auto complete built-in commands

Cleanup

• Make sure all our temporary nushell-number-random text files are cleaned up Delete tmp file on exit #100

Pre-Publish

• Update readme with more screenshots or gifs showing new features
• Update repo description
• Update changelog
• Update version
• Update regexes

[sophiajt]

I'd also like to fix variable completions when inside of a block that introduces a new variable. Currently I think we only see top-level variables.